1900963 - [Thunderbird] Intermittent toolkit/components/featuregates/test/unit/test_FeatureGate.js | Thunderbird failure

Status: RESOLVED FIXED

(Toolkit :: FeatureGate, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: martin [at] humanoids.be
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=461257161&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cT0Ci1dCSam7ZYFTDaCg4A/runs/0/artifacts/public/logs/live_backing.log

---

It seems the patch https://hg.mozilla.org/mozilla-central/rev/1974e2a74ac39c641354390e542c0280c843380b#l4.22 added an import for Targeting.sys.mjs in messaging-system, which is only included in browser builds: https://searchfox.org/mozilla-central/rev/fa86401b80f19afb6ed9bfca127ecc5e3a6f0cdc/toolkit/components/moz.build#133-134

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1896187

:Gijs, since you are the author of the regressor, bug 1896187, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[:Gijs (he/him)]

Do featuregates actually need to work in thunderbird? Does Nimbus work in TB? Nimbus already depends on this code and is also unconditionally built as part of toolkit ( https://searchfox.org/mozilla-central/rev/59d854a90e036cfa77f3c5b70c8c6ef1d60ebb98/toolkit/components/moz.build#136 ). I just copied part of it, and filed bug 1898012 about exactly this general issue - but I didn't think there was concrete breakage that I was creating that didn't previously exist.

Comment 3

[Intermittent Failures Robot]

105 failures in 672 pushes (0.156 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 105

Platform and build breakdown:

• windows11-64-2009-qr: 28
  • opt: 14
  • debug: 14
• linux1804-64-qr: 14
  • opt: 7
  • debug: 7
• windows11-32-2009-qr: 14
  • opt: 7
  • debug: 7
• macosx1015-64-qr: 14
  • opt: 7
  • debug: 7
• macosx1015-64-shippable-qr: 7
  • opt: 7
• windows11-32-2009-shippable-qr: 7
  • opt: 7
• linux1804-64-shippable-qr: 7
  • opt: 7
• windows11-64-2009-shippable-qr: 14
  • opt: 14

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1900963&startday=2024-06-06&endday=2024-06-06&tree=all

Comment 4

[Magnus Melin [:mkmelin]]

Nimbus isn't used in Thunderbird (not sure how much of it would just-work). It is included mostly since tests depend on it. (And we might want to utilize nimbus in the future.)

Comment 5

[Martin Giger [:freaktechnik]]

(In reply to :Gijs (he/him) from comment #2)

Do featuregates actually need to work in thunderbird?

We do depend on the masonry grid being available: https://searchfox.org/mozilla-central/rev/d3fea1aa852bb3a353a0a4a875c3685da11ce39b/toolkit/components/featuregates/Features.toml#20 and there's probably places in toolkit we use that are using feature gates - even if we don't care about flipping them.

Does Nimbus work in TB? Nimbus already depends on this code and is also unconditionally built as part of toolkit ( https://searchfox.org/mozilla-central/rev/59d854a90e036cfa77f3c5b70c8c6ef1d60ebb98/toolkit/components/moz.build#136 ).

I wonder if that code just isn't hit in tests then...

Comment 6

[:Gijs (he/him)]

(In reply to Martin Giger [:freaktechnik] from comment #5)

(In reply to :Gijs (he/him) from comment #2)

Do featuregates actually need to work in thunderbird?

We do depend on the masonry grid being available: https://searchfox.org/mozilla-central/rev/d3fea1aa852bb3a353a0a4a875c3685da11ce39b/toolkit/components/featuregates/Features.toml#20

The value of the feature being enabled depends purely on the pref's value, which is not controlled directly by featuregates. You don't need featuregates for that.

and there's probably places in toolkit we use that are using feature gates - even if we don't care about flipping them.

I don't think there are - there's only about:support because it lists enabled/disabled features, and that already bails out on android. It could be made to feature-detect instead, or also bail out on Thunderbird.

Does Nimbus work in TB? Nimbus already depends on this code and is also unconditionally built as part of toolkit ( https://searchfox.org/mozilla-central/rev/59d854a90e036cfa77f3c5b70c8c6ef1d60ebb98/toolkit/components/moz.build#136 ).

I wonder if that code just isn't hit in tests then...

The tests are disabled in Thunderbird... https://searchfox.org/mozilla-central/rev/d3fea1aa852bb3a353a0a4a875c3685da11ce39b/toolkit/components/nimbus/test/unit/xpcshell.toml#6-9

So would an appropriate solution here be to just disable the featuregate tests too? And/or, unship featuregates entirely on thunderbird?

Comment 7

[:Gijs (he/him)]

... and looks like Thunderbird's about:support also doesn't list featuregates:

https://searchfox.org/comm-central/rev/c327d6178ae0936bd6a6c63c62c4f5132b7f75f6/mail/components/about-support/content/aboutSupport.xhtml#504-519

Comment 8

[Martin Giger [:freaktechnik]]

(In reply to :Gijs (he/him) from comment #6)

The value of the feature being enabled depends purely on the pref's value, which is not controlled directly by featuregates. You don't need featuregates for that.

Ah great, so the feature gates infrastructure is to flip prefs.

I don't think there are - there's only about:support because it lists enabled/disabled features, and that already bails out on android. It could be made to feature-detect instead, or also bail out on Thunderbird.

We don't use the experimentalFeatures snapshot, but yeah our about:support test is failing because the snapshot is currently being gathered.

So would an appropriate solution here be to just disable the featuregate tests too? And/or, unship featuregates entirely on thunderbird?

We would have to at least also bail out in about:support, at which point I guess it might make sense to match the state of it on android? I think because we don't intentionally consume it whatever makes the most sense from a toolkit perspective is the best way forward.

Comment 9

[:Gijs (he/him)]

Well, the long-term fix is to architect this set of things better... but that's a substantial project and even at the end of this it sounds like TB doesn't benefit from shipping this code so it might as well not?

Comment 10

[:Gijs (he/him)]

Attachment: Bug 1900963 - only ship featuregates on desktop firefox and avoid calling it in aboutSupport in other apps, r?freaktechnik

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/601df0d20931
only ship featuregates on desktop firefox and avoid calling it in aboutSupport in other apps, r=freaktechnik

Comment 12

[Intermittent Failures Robot]

65 failures in 526 pushes (0.124 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• comm-central: 65

Platform and build breakdown:

• linux1804-64-qr: 14
  • debug: 7
  • opt: 7
• linux1804-64-shippable-qr: 6
  • opt: 6
• windows11-64-2009-qr: 12
  • debug: 6
  • opt: 6
• macosx1015-64-qr: 12
  • debug: 7
  • opt: 5
• windows11-32-2009-shippable-qr: 3
  • opt: 3
• windows11-64-2009-shippable-qr: 6
  • opt: 6
• macosx1015-64-shippable-qr: 6
  • opt: 6
• windows11-32-2009-qr: 6
  • debug: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1900963&startday=2024-06-07&endday=2024-06-07&tree=all

Comment 13

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/601df0d20931

Comment 14

[Intermittent Failures Robot]

170 failures in 3649 pushes (0.047 failures/push) were associated with this bug in the last 7 days.

This is the #1 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 170

Platform and build breakdown:

• linux1804-64-qr: 28
  • debug: 14
  • opt: 14
• linux1804-64-shippable-qr: 13
  • opt: 13
• windows11-64-2009-qr: 40
  • debug: 20
  • opt: 20
• macosx1015-64-qr: 26
  • debug: 14
  • opt: 12
• windows11-32-2009-shippable-qr: 10
  • opt: 10
• windows11-64-2009-shippable-qr: 20
  • opt: 20
• macosx1015-64-shippable-qr: 13
  • opt: 13
• windows11-32-2009-qr: 20
  • opt: 10
  • debug: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1900963&startday=2024-06-03&endday=2024-06-09&tree=all