1896503 - WR SVG Filters: Integrate new SVGFE code path with Gecko

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P2)

Description

[Ashley Hale [:ahale]]

Now that we have the SVGFE code in WebRender we need to hook it up in Gecko so it is user visible and improves performance.

Comment 1

[Ashley Hale [:ahale]]

Attachment: Bug 1896503 - Implement FilterInstance code to send SVG filter graph to WebRender

Comment 2

[Markus Stange [:mstange]]

Attachment: testcase exploring filter regions

I found this testcase in the folder where I keep all my test cases, and noticed that some pieces in it show different behavior with the patch applied. IIRC all browsers are already fairly inconsistent about the behavior here but I think it's valuable to only change Firefox's behavior with intention and not by accident, so it's worth investigating what's causing the differences in behavior. This doesn't need to block the landing of this patch as the bugs are likely orthogonal, and because gfx.webrender.svg-filter-effects is nightly-only for now.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ff43ea4a5c9
Implement FilterInstance code to send SVG filter graph to WebRender r=mstange

Comment 4

[Ashley Hale [:ahale]]

(In reply to Markus Stange [:mstange] from comment #2)

Created attachment 9405581 [details]
testcase exploring filter regions

I found this testcase in the folder where I keep all my test cases, and noticed that some pieces in it show different behavior with the patch applied. IIRC all browsers are already fairly inconsistent about the behavior here but I think it's valuable to only change Firefox's behavior with intention and not by accident, so it's worth investigating what's causing the differences in behavior. This doesn't need to block the landing of this patch as the bugs are likely orthogonal, and because gfx.webrender.svg-filter-effects is nightly-only for now.

I'll give this test case a look, if it is inconsistent between browsers then I'd like to turn it into a set of WPT tests.

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing reftest failures

Backout link

Push with failures

Failure log

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfd01427a5e8
Backed out changeset 9ff43ea4a5c9 for causing reftest failures

Comment 7

[tszentpeteri]

Backout merged to central:
https://hg.mozilla.org/mozilla-central/rev/b685b81b960a8c2d5684d322283c63dc477c7736

Comment 8

[Ashley Hale [:ahale]]

Backout was caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1901884 which is an unrelated intermittent.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2eaf893e115
Implement FilterInstance code to send SVG filter graph to WebRender r=mstange

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c2eaf893e115

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This change causes gpu process crashes, e.g. bp-173238fd-2e8f-474e-a9ae-227270240619. The issue reproduces here with https://developer.valvesoftware.com/wiki/Source/en#/media/File:Screenshot-CSS-Source_engine_comparison.jpg

The change will be reverted in the next Nightly.

Comment 12

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/cd19aab35756

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 desktop browser crashes on nightly

:ahale, could you consider increasing the severity of this top-crash bug?

For more information, please visit BugBot documentation.

Comment 14

[Timothy Nikkel (:tnikkel)]

This bug was tagged with the crash signature that it caused, and it has been backed out, so it doesn't make sense to increase the severity of this bug because of the crash it caused. Clearing needinfo.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/beec388d4b0e
Implement FilterInstance code to send SVG filter graph to WebRender r=mstange,gw

Comment 16

[Ashley Hale [:ahale]]

Status: The above diff has addressed the panic that was occurring on certain websites where an SVG filter graph was applied to a picture and then also an Opacity filter (which is not SVG) was being applied to the same picture.

Comment 17

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/beec388d4b0e

Comment 18

[Ashley Hale [:ahale]]

I'm working on this.

Comment 19

[Ashley Hale [:ahale]]

Just FYI the topcrash should have been resolved already by https://phabricator.services.mozilla.com/D214912 which also changed the error message and made it have a more spec-compliant failure mode if there is a mixed filter chain (which should only be possible in the case of opacity, which is handled by that patch).