1896623 - "Customize sidebar" menu option being added to Sidebar menubar menu

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P2)

Description

[Sarah Clements [:sclements]]

On currently Nightly (128.01) with the sidebar.revamp pref flipped to true the string is not visible for the Bookmarks. This might have been caused by bug 1891775. Even though its not in the customization menu yet, we should preserve the entry point for all sidebar panels in the Sidebar menubar and it clicking on it should go to the correct panel (just clicking on that empty space opened the Customization panel). Let's add a test to guard against future regression.

Comment 1

[Rob Wu [:robwu]]

A test was changed in an unrelated change, and suspected to be related to the report here. For more details, see https://phabricator.services.mozilla.com/D207787?id=859897#inline-1161549

Would be nice to check whether the change in browser_sidebar_persist.js can be reverted without test failures. These changes were described in the above thread and the diff is visible at https://phabricator.services.mozilla.com/D207787?id=861270#change-5O9UJWQKVoak

Comment 2

[Kelly Cochrane [:kcochrane]]

I disagree that the Bookmarks menu option should be shown there when the sidebar.revamp pref has been flipped on. It's not hidden in the sidebar, it's not available whatsoever, so that menu option would currently do nothing. I imagine this menu is populated using what's available in SidebarController.sidebars

What's happening is that the new Customize sidebar menu option is being added as an option in the View > Sidebars menu, so I'm making this a regression of bug 1891775.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1891775

Comment 4

[Sarah Clements [:sclements]]

(In reply to Kelly Cochrane [:kcochrane] from comment #2)

I disagree that the Bookmarks menu option should be shown there when the sidebar.revamp pref has been flipped on. It's not hidden in the sidebar, it's not available whatsoever, so that menu option would currently do nothing. I imagine this menu is populated using what's available in SidebarController.sidebars

What's happening is that the new Customize sidebar menu option is being added as an option in the View > Sidebars menu, so I'm making this a regression of bug 1891775.

As discussed on slack, we do need to preserve access to the bookmarks sidebar panel so we'll need to re-enable it and ensure its added back to the Sidebar menu. However, that will be spun off into a separate bug 1896658 since you've found the blank menu item to be a different issue altogether.

Comment 5

[Haik Aftandilian [:haik]]

@Kelly, could you confirm if this has an impact on 127?

Comment 6

[Sarah Clements [:sclements]]

(In reply to Haik Aftandilian [:haik] from comment #5)

@Kelly, could you confirm if this has an impact on 127?

No, this is only visible with the sidebar.revamp pref flipped to true. Its set to false by default in profile.js.

Comment 7

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1896623 - Ensure 'customize sidebar' option isn't added to menu bar View > Sidebars menu

Comment 8

[Daniel Holbert [:dholbert]]

(In reply to Sarah Clements [:sclements] from comment #6)

(In reply to Haik Aftandilian [:haik] from comment #5)

@Kelly, could you confirm if this has an impact on 127?

No, this is only visible with the sidebar.revamp pref flipped to true. Its set to false by default in profile.js.

[regression triage note:]
This is true for Firefox 128 nightly, too:
https://searchfox.org/mozilla-central/rev/893f350260faac2ee6bf2b14c627d55eb2babfb0/browser/app/profile/firefox.js#1876

So in terms of user-facing impact, this doesn't affect any of our release channels right now (in the absence of an explicit pref-flip to turn on this experimental feature).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d03f0bffe07
Ensure 'customize sidebar' option isn't added to menu bar View > Sidebars menu r=sidebar-reviewers,sclements

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8d03f0bffe07