1896677 - Home and newtab weather widget fetch might need a retry feature

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Scott [:thecount] Downe]

If the weather fetch fails, we don't try again until the next system tick/update.

We can add some retry logic that runs before waiting for the next system tick/update.

Comment 1

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: We intend to launch a weather experiment in 127. It should be a low risk, small set of changes.

If the weather data fetch fails a retry is very likely to work, and would reduce the number of errors the user sees. After retrying 3 times if we still don't have a successful response, then we should display the error.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox127 (beta). However, the bug still isn't assigned.

:amy, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 3

[Scott [:thecount] Downe]

I think we're ok if this doesn't make it in, but it may be easy and we may get time this week. If so we might consider taking it.

Comment 4

[Scott [:thecount] Downe]

Attachment: Bug 1896677 - Home and newtab weather widget fetch retry

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e70387f1e9d
Home and newtab weather widget fetch retry r=home-newtab-reviewers,nbarrett

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/2e70387f1e9d

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 8

[Scott [:thecount] Downe]

Attachment: Bug 1896677 - Home and newtab weather widget fetch retry

Original Revision: https://phabricator.services.mozilla.com/D214314

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Should stop some errors for users during an experiment
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Hard to test errors for this, but more so what's important is some regression tests on a new profile still displays the weather widget on newtab
• Risk associated with taking this patch: Low
• Explanation of risk level: Just a few lines, adding a loop, in a preffed off feature
• String changes made/needed: None
• Is Android affected?: no

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/a2061ccfc0c9

Comment 11

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Firefox RC 128.0 (Build ID: 20240701154223) and the latest Nightly 129.0a1 (Build ID: 20240703213305) on Windows 10x64, macOS 14.4.1 and Linux Mint 20.1 x64.
In order to verify this I have used the following scenarios.

• On new profiles, I have disabled the internet connection and the "Weather data is not available right now" error is correctly displayed. After enabling the internet connection and a check is performed the weather is correctly displayed.
• Using a VPN, I have changed the location multiple times to verify that the weather is correctly displayed.
• I have disabled/enabled multiple times the Weather feature from the settings menu from the New Tab page, and the weather was correctly displayed each time.