Closed
Bug 1896732
Opened 4 months ago
Closed 4 months ago
Write a mach command to generate a Glean event definition for a named Legacy Telemetry event definition
Categories
(Toolkit :: Telemetry, task, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
128 Branch
| Tracking | Status | |
|---|---|---|
| firefox128 | --- | fixed |
People
(Reporter: chutten, Assigned: chutten)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
It would make the DCT Team's job of migrating existing Legacy Telemetry event collections to Glean easier if there were a tool that could take a named Legacy Telemetry event and generate a Glean event definition for it. Sort of like the inverse of ./mach event-into-legacy
|
Assignee | |
Comment 1•4 months ago
|
||
Currently only supports events.
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a1f42ba0143
Introducing `mach gifft` to generate Glean metric definitions for named Legacy probes r=TravisLong
|
||
Comment 3•4 months ago
•
|
||
Backed out for causing fatal errors while processing mozbuild file.
- Backout link
- Push with failures
- Failure Log for bustage
- Failure Log for python unit test fail
- Failure log:
[task 2024-05-16T20:20:27.307Z] 20:20:27 INFO - creating ./config.data
[task 2024-05-16T20:20:27.315Z] 20:20:27 INFO - js/src> Refreshing /builds/worker/checkouts/gecko/js/src/old-configure with /builds/worker/checkouts/gecko/build/autoconf/autoconf.sh
[task 2024-05-16T20:20:27.341Z] 20:20:27 INFO - js/src> loading cache ./config.cache
[task 2024-05-16T20:20:27.349Z] 20:20:27 INFO - js/src> checking host system type... x86_64-pc-linux-gnu
[task 2024-05-16T20:20:27.355Z] 20:20:27 INFO - js/src> checking target system type... i686-pc-linux-gnu
[task 2024-05-16T20:20:27.361Z] 20:20:27 INFO - js/src> checking build system type... x86_64-pc-linux-gnu
[task 2024-05-16T20:20:27.361Z] 20:20:27 INFO - js/src> cross compiling from x86_64-pc-linux-gnu to i686-pc-linux-gnu
[task 2024-05-16T20:20:27.361Z] 20:20:27 INFO - js/src> checking for gcc... (cached) /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang --sysroot /builds/worker/fetches/sysroot-i686-linux-gnu -std=gnu99 -m32
[task 2024-05-16T20:20:27.362Z] 20:20:27 INFO - js/src> checking whether the C compiler (/builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang --sysroot /builds/worker/fetches/sysroot-i686-linux-gnu -std=gnu99 -m32 -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -fcrash-diagnostics-dir=/builds/worker/artifacts -fuse-ld=lld -Wl,-rpath-link,/builds/worker/fetches/sysroot-i686-linux-gnu/lib/i386-linux-gnu -Wl,-rpath-link,/builds/worker/fetches/sysroot-i686-linux-gnu/usr/lib/i386-linux-gnu ) works... (cached) yes
[task 2024-05-16T20:20:27.362Z] 20:20:27 INFO - js/src> checking whether the C compiler (/builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang --sysroot /builds/worker/fetches/sysroot-i686-linux-gnu -std=gnu99 -m32 -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -fcrash-diagnostics-dir=/builds/worker/artifacts -fuse-ld=lld -Wl,-rpath-link,/builds/worker/fetches/sysroot-i686-linux-gnu/lib/i386-linux-gnu -Wl,-rpath-link,/builds/worker/fetches/sysroot-i686-linux-gnu/usr/lib/i386-linux-gnu ) is a cross-compiler... yes
[task 2024-05-16T20:20:27.363Z] 20:20:27 INFO - js/src> checking whether we are using GNU C... (cached) yes
[task 2024-05-16T20:20:27.363Z] 20:20:27 INFO - js/src> checking whether /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang --sysroot /builds/worker/fetches/sysroot-i686-linux-gnu -std=gnu99 -m32 accepts -g... (cached) yes
[task 2024-05-16T20:20:27.363Z] 20:20:27 INFO - js/src> checking for c++... (cached) /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-i686-linux-gnu -m32
[task 2024-05-16T20:20:27.364Z] 20:20:27 INFO - js/src> checking whether the C++ compiler (/builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-i686-linux-gnu -m32 -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -fcrash-diagnostics-dir=/builds/worker/artifacts -fuse-ld=lld -Wl,-rpath-link,/builds/worker/fetches/sysroot-i686-linux-gnu/lib/i386-linux-gnu -Wl,-rpath-link,/builds/worker/fetches/sysroot-i686-linux-gnu/usr/lib/i386-linux-gnu ) works... (cached) yes
[task 2024-05-16T20:20:27.364Z] 20:20:27 INFO - js/src> checking whether the C++ compiler (/builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-i686-linux-gnu -m32 -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -fcrash-diagnostics-dir=/builds/worker/artifacts -fuse-ld=lld -Wl,-rpath-link,/builds/worker/fetches/sysroot-i686-linux-gnu/lib/i386-linux-gnu -Wl,-rpath-link,/builds/worker/fetches/sysroot-i686-linux-gnu/usr/lib/i386-linux-gnu ) is a cross-compiler... yes
[task 2024-05-16T20:20:27.364Z] 20:20:27 INFO - js/src> checking whether we are using GNU C++... (cached) yes
[task 2024-05-16T20:20:27.365Z] 20:20:27 INFO - js/src> checking whether /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-i686-linux-gnu -m32 accepts -g... (cached) yes
[task 2024-05-16T20:20:27.365Z] 20:20:27 INFO - js/src> checking for llvm-symbolizer... (cached) /builds/worker/fetches/llvm-symbolizer/bin/llvm-symbolizer
[task 2024-05-16T20:20:27.367Z] 20:20:27 INFO - js/src> checking for llvm-symbolizer... (cached) /builds/worker/fetches/llvm-symbolizer/bin/llvm-symbolizer
[task 2024-05-16T20:20:27.420Z] 20:20:27 INFO - js/src> checking whether the linker supports Identical Code Folding... (cached) no
[task 2024-05-16T20:20:27.420Z] 20:20:27 INFO - js/src> checking whether we're trying to statically link with libstdc++... (cached) no
[task 2024-05-16T20:20:27.420Z] 20:20:27 INFO - js/src> checking whether 64-bits std::atomic requires -latomic... (cached) no
[task 2024-05-16T20:20:27.422Z] 20:20:27 INFO - js/src> checking for gethostbyname_r in -lc_r... (cached) no
[task 2024-05-16T20:20:27.423Z] 20:20:27 INFO - js/src> checking for socket in -lsocket... (cached) no
[task 2024-05-16T20:20:27.425Z] 20:20:27 INFO - js/src> checking for pthread_create in -lpthreads... (cached) no
[task 2024-05-16T20:20:27.426Z] 20:20:27 INFO - js/src> checking for pthread_create in -lpthread... (cached) yes
[task 2024-05-16T20:20:28.082Z] 20:20:28 INFO - js/src> checking whether /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang --sysroot /builds/worker/fetches/sysroot-i686-linux-gnu -std=gnu99 -m32 accepts -pthread... yes
[task 2024-05-16T20:20:28.158Z] 20:20:28 INFO - js/src> checking for valid optimization flags... yes
[task 2024-05-16T20:20:28.163Z] 20:20:28 INFO - js/src> checking what kind of list files are supported by the linker... (cached) linkerlist
[task 2024-05-16T20:20:28.167Z] 20:20:28 INFO - js/src> checking for malloc.h... (cached) yes
[task 2024-05-16T20:20:28.168Z] 20:20:28 INFO - js/src> checking whether malloc_usable_size definition can use const argument... (cached) no
[task 2024-05-16T20:20:28.188Z] 20:20:28 INFO - js/src> checking for valloc in malloc.h... yes
[task 2024-05-16T20:20:28.206Z] 20:20:28 INFO - js/src> checking for valloc in unistd.h... no
[task 2024-05-16T20:20:28.224Z] 20:20:28 INFO - js/src> checking for _aligned_malloc in malloc.h... no
[task 2024-05-16T20:20:28.230Z] 20:20:28 INFO - js/src> creating ./config.data
[task 2024-05-16T20:20:28.237Z] 20:20:28 INFO - Creating config.status
[task 2024-05-16T20:20:28.495Z] 20:20:28 INFO - Reticulating splines...
[task 2024-05-16T20:20:33.794Z] 20:20:33 ERROR - Traceback (most recent call last):
[task 2024-05-16T20:20:33.794Z] 20:20:33 INFO - File "/builds/worker/checkouts/gecko/configure.py", line 351, in <module>
[task 2024-05-16T20:20:33.794Z] 20:20:33 INFO - sys.exit(main(sys.argv))
[task 2024-05-16T20:20:33.794Z] 20:20:33 INFO - File "/builds/worker/checkouts/gecko/configure.py", line 176, in main
[task 2024-05-16T20:20:33.794Z] 20:20:33 INFO - return config_status(config)
[task 2024-05-16T20:20:33.794Z] 20:20:33 INFO - File "/builds/worker/checkouts/gecko/configure.py", line 300, in config_status
[task 2024-05-16T20:20:33.795Z] 20:20:33 INFO - return config_status(args=[], **sanitized_config)
[task 2024-05-16T20:20:33.795Z] 20:20:33 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/config_status.py", line 201, in config_status
[task 2024-05-16T20:20:33.795Z] 20:20:33 INFO - pool = BackendPool(definitions, processes=processes)
[task 2024-05-16T20:20:33.795Z] 20:20:33 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/config_status.py", line 54, in __init__
[task 2024-05-16T20:20:33.795Z] 20:20:33 INFO - definitions = list(definitions)
[task 2024-05-16T20:20:33.795Z] 20:20:33 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 156, in emit
[task 2024-05-16T20:20:33.796Z] 20:20:33 INFO - objs = list(emitfn(out))
[task 2024-05-16T20:20:33.796Z] 20:20:33 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1332, in emit_from_context
[task 2024-05-16T20:20:33.796Z] 20:20:33 INFO - for obj in self._process_generated_files(context):
[task 2024-05-16T20:20:33.796Z] 20:20:33 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1720, in _process_generated_files
[task 2024-05-16T20:20:33.799Z] 20:20:33 INFO - raise SandboxValidationError(
[task 2024-05-16T20:20:33.800Z] 20:20:33 INFO - mozbuild.frontend.reader.SandboxValidationError:
[task 2024-05-16T20:20:33.800Z] 20:20:33 INFO - ==============================
[task 2024-05-16T20:20:33.800Z] 20:20:33 INFO - FATAL ERROR PROCESSING MOZBUILD FILE
[task 2024-05-16T20:20:33.800Z] 20:20:33 INFO - ==============================
[task 2024-05-16T20:20:33.800Z] 20:20:33 INFO - The error occurred while processing the following file or one of the files it includes:
[task 2024-05-16T20:20:33.800Z] 20:20:33 INFO - /builds/worker/checkouts/gecko/toolkit/components/glean/moz.build
[task 2024-05-16T20:20:33.800Z] 20:20:33 INFO - The error occurred when validating the result of the execution. The reported error is:
[task 2024-05-16T20:20:33.801Z] 20:20:33 INFO - Input for generating ('GleanMetrics.h', 'GleanJSMetricsLookup.h', 'GleanJSMetricsLookup.cpp', 'api/src/metrics.rs') does not exist: /builds/worker/checkouts/gecko/browser/actors/metrics.yaml
[task 2024-05-16T20:20:34.399Z] 20:20:34 INFO - *** Fix above errors and then restart with "./mach build"
[task 2024-05-16T20:20:34.508Z] 20:20:34 INFO - Return code: 1
[task 2024-05-16T20:20:34.508Z] 20:20:34 WARNING - setting return code to 2
[task 2024-05-16T20:20:34.508Z] 20:20:34 FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2024-05-16T20:20:34.508Z] 20:20:34 FATAL - Running post_fatal callback...
[task 2024-05-16T20:20:34.509Z] 20:20:34 FATAL - Exiting -1
[task 2024-05-16T20:20:34.509Z] 20:20:34 INFO - [mozharness: 2024-05-16 20:20:34.509007Z] Finished build step (failed)
[task 2024-05-16T20:20:34.509Z] 20:20:34 INFO - Running post-run listener: _parse_build_tests_ccov
[task 2024-05-16T20:20:34.509Z] 20:20:34 INFO - Running command: ['/builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/common/bin/python', 'mach', 'python', 'testing/parse_build_tests_ccov.py'] in /builds/worker/checkouts/gecko
[task 2024-05-16T20:20:34.509Z] 20:20:34 INFO - Copy/paste: /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/common/bin/python mach python testing/parse_build_tests_ccov.py
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - Using env: {'ACCEPTED_MAR_CHANNEL_IDS': 'firefox-mozilla-central',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'ASAN_OPTIONS': 'detect_leaks=0',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'DEBIAN_FRONTEND': 'noninteractive',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'DISPLAY': ':2',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'EXTRA_MOZHARNESS_CONFIG': '{"mozconfig_variant": "nightly-fuzzing-asan", '
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - '"objdir": "obj-build"}',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'GECKO_BASE_REPOSITORY': 'https://hg.mozilla.org/mozilla-unified',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'GECKO_HEAD_REPOSITORY': 'https://hg.mozilla.org/integration/autoland',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'GECKO_HEAD_REV': '0a1f42ba0143db4132e04915a21f1b9c44931939',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'GECKO_PATH': '/builds/worker/checkouts/gecko',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'GRCOV_PATH': '/builds/worker/fetches/grcov/grcov',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'HG_SHARE_BASE_DIR': '/builds/hg-shared',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'HG_STORE_PATH': '/builds/worker/checkouts/hg-store',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'HOME': '/builds/worker',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'HOSTNAME': 'taskcluster-worker',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'LC_ALL': 'C',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'LC_CTYPE': 'C.UTF-8',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'LOGNAME': 'worker',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE': 'system',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'MACH_MAIN_PID': '58',
[task 2024-05-16T20:20:34.510Z] 20:20:34 INFO - 'MACH_SYSTEM_ASSERTED_COMPATIBLE_WITH_COMMON_SITE': '1',
[task 2024-05-16T20:20:34.511Z] 20:20:34 INFO - 'MACH_SYSTEM_ASSERTED_COMPATIBLE_WITH_MACH_SITE': '1',
[task 2024-05-16T20:20:34.511Z] 20:20:34 INFO - 'MAR_CHANNEL_ID': 'firefox-mozilla-central',
[task 2024-05-16T20:20:34.511Z] 20:20:34 INFO - 'MH_BRANCH': 'autoland',
[task 2024-05-16T20:20:34.511Z] 20:20:34 INFO - 'MH_BUILD_POOL': 'taskcluster',
[task 2024-05-16T20:20:34.511Z] 20:20:34 INFO - 'MH_CUSTOM_BUILD_VARIANT_CFG': 'fuzzing-asan-tc',
[task 2024-05-16T20:20:34.511Z] 20:20:34 INFO - 'MOZBUILD_STATE_PATH': '/builds/worker/.mozbuild',
[task 2024-05-16T20:20:34.511Z] 20:20:34 INFO - 'MOZHARNESS_ACTIONS': 'get-secrets build',
[task 2024-05-16T20:20:34.511Z] 20:20:34 INFO - 'MOZHARNESS_CONFIG': 'builds/releng_base_firefox.py '
[task 2024-05-16T20:20:34.511Z] 20:20:34 INFO - 'builds/releng_base_linux_32_builds.py',
[task 2024-05-16T20:20:34.511Z] 20:20:34 INFO - 'MOZHARNESS_SCRIPT': 'mozharness/scripts/fx_desktop_build.py',
[task 2024-05-16T20:20:34.511Z] 20:20:34 INFO - 'MOZPYTHONHOME': '/builds/worker/fetches/python',
[task 2024-05-16T20:20:34.511Z] 20:20:34 INFO - 'MOZ_ARTIFACT_PLATFORM': 'linux-asan-fuzzing',
[task 2024-05-16T20:20:34.511Z] 20:20:34 INFO - 'MOZ_AUTOMATION': '1',
Flags: needinfo?(chutten)
|
|
Assignee | |
Comment 4•4 months ago
|
||
Ah, whoops, that snuck in from a manual test run.
Flags: needinfo?(chutten)
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e54c170400b0
Introducing `mach gifft` to generate Glean metric definitions for named Legacy probes r=TravisLong
|
||
Comment 6•4 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox128:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•