1894530 - Augment the Glean Interface For Firefox Telemetry (GIFFT) to support the Legacy Telemetry event `value` parameter

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Chris H-C :chutten]

Legacy Telemetry Events have the following recording API: recordEvent(aCategory, aMethod, aObject, aValue, aExtra)

GIFFT can successfully map to all of those parameters (the telemetry_mirror property specifies a specific combination of category+method+object, and aExtra passes through unchanged from Glean's record(aExtra) (modulo types and differing limits in the systems about how many and what length of extra keys and values are permitted)) except aValue.

In order to support migrating all existing Legacy Telemetry event recording to Glean APIs, GIFFT's going to need to handle that last piece.

This bug is about enhancing GIFFT to support some mechanism for supplying aValue. This will probably include:

• Some additional FOG-only metrics.yaml property (like telemetry_mirror or use_ohttp)
• Changes to codegen to make that information available to t/c/g/bindings/private/Event.cpp
• Documentation in the GIFFT docs about how and when to use this, and whether the different limits in Legacy and Glean mean certain values will be truncated, and at what times, and are those truncations instrumented
• Tests! Especially about that truncation stuff

Comment 1

[Travis Long [:travis_]|PTO]

Attachment: Bug 1894530 - Augment the Glean Interface For Firefox Telemetry (GIFFT) to support the Legacy Telemetry event `value` parameter.r?chutten!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e205f755a69c
Augment the Glean Interface For Firefox Telemetry (GIFFT) to support the Legacy Telemetry event `value` parameter.r=chutten

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e205f755a69c