1896864 - Attempt to override an existing message - "select-translations-panel-translating-placeholder-text" from preview/select-translations.ftl

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[:Gijs (out for now; he/him)]

I'm seeing a lot of these errors in the browser console in 126 rc on the beta channel. I'm not quite sure what I've done to trigger them.

Comment 1

[:Gijs (out for now; he/him)]

Looks like this file no longer exists on (new, 127) beta and central, but existed in 126.

flod, is this "just" a side-effect of cross-tree l10n where my en-GB build has the now-translated values for the 127/128 branches and they have the same ID as the "preview" ones in the 126 shipped bits, and 126 loads both preview and translated items?

Comment 2

[:Gijs (out for now; he/him)]

(In reply to :Gijs (he/him) from comment #0)

I'm not quite sure what I've done to trigger them.

Looks like I get a few dozen of these every time I open a new browser window. :-(

Comment 3

[:Gijs (out for now; he/him)]

Flod's out, Eemeli probably knows...

Comment 4

[Eemeli Aro [:eemeli]]

(In reply to :Gijs (he/him) from comment #1)

Looks like this file no longer exists on (new, 127) beta and central, but existed in 126.

flod, is this "just" a side-effect of cross-tree l10n where my en-GB build has the now-translated values for the 127/128 branches and they have the same ID as the "preview" ones in the 126 shipped bits, and 126 loads both preview and translated items?

Yeah, this is almost certainly due to the changes in bug 1893022, where the strings from browser/locales-preview/select-translations.ftl were moved to browser/locales/en-US/browser/translations.ftl, a file that already existed. Because we merge contents from all branches for localization, and don't filter the strings for each release, this means that the 126 localizations now include the strings in their browser/translations.ftl, as well as the non-localized browser/locales-preview/select-translations.ftl.

Which I didn't think about when telling Erik that doing this should be fine. And now I can replicate the issue of seeing the verbose browser console logging in the 126.0 release.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1893022

:nordzilla, since you are the author of the regressor, bug 1893022, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 6

[Eemeli Aro [:eemeli]]

I had a call with Erik, who suggested that uplifting the patch for bug 1893022 to firefox126 should fix this issue, and I agree. Doing so would remove the browser/locales-preview/select-translations.ftl file, which is causing the warning prints.

A secondary effect of this bug is that if browser.translations.select.enable is set to true, on 126 the user gets a localized experience, rather than an en-US experience, as the localized file is loaded before the unlocalized one.

Comment 8

[Donal Meehan [:dmeehan]]

Setting Fx126 to fixed since Bug 1893022 was uplifted to release.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gregtatum, could you have a look please?

For more information, please visit BugBot documentation.