1893022 - Move Select Translations Fluent Strings out of Preview

Status: VERIFIED FIXED

(Firefox :: Translations, task, P3)

Description

[Erik Nordin [:nordzilla]]

Description

To prepare for release, we need to move the Select Translations Fluent strings out of locales preview and into the en-US locale to be marked for translation by localizers.

---

Steps to implement

• Move the preview strings into en-US/browser/translations.ftl
• Migrate any strings that need it.
• Remove the preview file.
• Ensure that anything that depended on the preview file has the real file as a dependency as well.

---

Tests to implement

• Existing tests should provide sufficient coverage.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1893022 - Move Select Translations Fluent Strings out of Preview r=#fluent-reviewers!

Moves the Fluent strings for Select Translations out of
locales preview and into the en-US locale to mark them
to be translated by localizers for release.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9149d37cec8
Move Select Translations Fluent Strings out of Preview r=fluent-reviewers,flod

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b9149d37cec8

Comment 4

[Erik Nordin [:nordzilla]]

Attachment: Bug 1893022 - Move Select Translations Fluent Strings out of Preview r=eemeli

Moves the Fluent strings for Select Translations out of
locales preview and into the en-US locale to mark them
to be translated by localizers for release.

Original Revision: https://phabricator.services.mozilla.com/D208383

Comment 5

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Firefox 126 users who are not on the en-US locale will see console spam described in Bug 1896864
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Verify that the console spam described in Bug 1896864 no longer shows up in Firefox 126 release.
• Risk associated with taking this patch: Low Risk
• Explanation of risk level: It always feels risky uploading something into release, however the only changes here are to Fluent files and the markup that references them. No string values are changed. Values were only moved from a now-deleted preview Fluent file into a pre-existing Fluent file within the en-US locale.
• String changes made/needed: None
• Is Android affected?: no

Comment 6

[Daniel Bodea [:danibodea]]

I can reproduce this issue in beta v126.0b9 and 126.0RC. When opening a build with another language than en-US or when changing the language different than en-US (basically when a window of a build in a different language than en-US is painted) a spam of errors is displayed in the Browser Console:
Attempt to override an existing message: "main-context-menu-translate-selection". preview/select-translations.ftl
Attempt to override an existing message: "main-context-menu-translate-selection-to-language". preview/select-translations.ftl
Attempt to override an existing message: "main-context-menu-translate-link-text". preview/select-translations.ftl
Attempt to override an existing message: "main-context-menu-translate-link-text-to-language". preview/select-translations.ftl
Attempt to override an existing message: "select-translations-panel-header". preview/select-translations.ftl
Attempt to override an existing message: "select-translations-panel-from-label". preview/select-translations.ftl
Attempt to override an existing message: "select-translations-panel-to-label". preview/select-translations.ftl
Attempt to override an existing message: "select-translations-panel-copy-button". preview/select-translations.ftl
Attempt to override an existing message: "select-translations-panel-done-button". preview/select-translations.ftl
Attempt to override an existing message: "select-translations-panel-translate-full-page-button"
Windows 10, MacOS 11 and Ubuntu 22 have been tested along with the following languages: German, French, British English and Spanish.
(This issue only reproduces for languages supported by this feature, it would appear.)

These errors have stopped showing up in beta v127.0b3.

Comment 7

[Donal Meehan [:dmeehan]]

:nordzilla this patch failed to land due to conflicts with release in browser/locales-preview/select-translations.ftl
Could you please take a look?

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/78198cac1f1c

Comment 9

[Daniel Bodea [:danibodea]]

This issue still reproduces in the latest Release v126.0 (20240509170740) and it no longer occurs in Release v126.0.1 (20240526221752).
Tested in Windows 10, MacOS 11 and Ubuntu 22.