1896901 - [macOS] Using the Tab key to select the Portable Document Format (PDF) text inside the Open window will move it clipping the first letter

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: Screen Recording 2024-05-15 at 15.15.03.mov

Filed on request per comment 1896330#c9

Found in

• 128.0a1 (2024-05-15)

Affected versions

• 128.0a1 (2024-05-15)

Tested platforms

• Affected platforms: macOS12
• Unaffected platforms: Ubuntu 23, Windows 10x64

Steps to reproduce

1. Set PDF to Always ask in about:preferences.
2. Open a sample PDF (https://pdfobject.com/pdf/sample.pdf)
3. Using the tab keyboard ket focus the Portable Document Format text.

Expected result

• The text is not moved and clipped.

Actual result

• The text is moved and clipped.

Regression range

• This particular issue is seen after fixing bug 1896330. I will set this as the regressor.

Additional notes

• Attached a screen recording.
• It seems that on previous builds before bug 1896330 Tab selection between options was not possible (only the Portable Document Format (PDF) text could be selected)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1896330, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1896901 - Don't use an <input> for unknown content type file. r=dao!

This happens because the input minimum size doesn't depend on the value
text. There's an experimental CSS property to support something like
this, field-sizing:

https://developer.mozilla.org/en-US/docs/Web/CSS/field-sizing

Which is tracked on bug 1832409, but which we don't implement yet.

This makes the form minimum size account for the content, while keeping
text selectability. It's not ideal because there's no caret / Ctrl+A
etc, but it's probably an ok trade-off? Alternatively we can wontfix /
make this depend on implementing field-sizing.

Comment 3

[Pascal Chevrel:pascalc]

Emilio do you intend to land it in 128? Thanks

Comment 4

[Emilio Cobos Álvarez (:emilio)]

It's awaiting review.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Looks like dao is out till the 13th. If this does land in the next couple of weeks please request uplift if you feel it is not too risky, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9d225f27dac
Don't use an <input> for unknown content type file. r=dao,desktop-theme-reviewers

Comment 7

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/f9d225f27dac

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox128 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on Firefox 128 on macOS 11, following the STR from Comment 0.
Verified as fixed on the same OS using Firefox 129.0b9 (20240726091552).

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR128 when you get a chance.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9401965 [details]
Bug 1896901 - Don't use an <input> for unknown content type file. r=dao!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: see above
• User impact if declined: comment 0
• Fix Landed on Version: 129
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively niche dialog, verified by qa, has been around for a bit already.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9401965 [details]
Bug 1896901 - Don't use an <input> for unknown content type file. r=dao!

Approved for 128.2esr.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/945b673151f9

Comment 14

[Giorgia Nichita, Release Desktop QA]

Verified as fixed on macOS 11 using Firefox 128.2.0esr (20240826114743).