1896929 - Allow nsInputStreamChannel to have an arbitrary content type set on it

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

nsInputStreamChannel inherits from nsBaseChannel, meaning that it inherits the nsBaseChannel SetContentType method. That method parses the passed in content type with net_ParseContentType here, and this means that anything after a ; will be truncated from the content type.

I'd like to propose that we override the SetContentType method to skip this parsing / truncation. The reason for this is that I'd like to feed an nsIInputStream into the multipart/mixed stream converter (which only accepts an nsIChannel as its source of bytes), and the multipart/mixed stream converter expects the content type to include boundary information after the MIME type.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1896929 - Allow nsInputStreamChannel to have an arbitrary content type set on it. r?valentin!

This allows us to craft an nsIInputStreamChannel that can be used with the
multipart/mixed stream converter.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/248b14f05067
Allow nsInputStreamChannel to have an arbitrary content type set on it. r=valentin,necko-reviewers

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/248b14f05067