1914250 - Message window freezes after clicking mailto: link

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[mozilla]

Attachment: Thunderbird message.txt

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Safari/537.36 Edg/127.0.0.0

Steps to reproduce:

I received a message from Stanford (not spam or a hoax) including a "mailto" link to request a service. I clicked on that link.

Actual results:

The message preview window went blank and no outgoing message was generated. After that, I could not view any message in any folder, including local folders, until I restarted Thunderbird.

Expected results:

An outgoing message should have been generated and the preview window should have remain operative.

I forwarded the message to myself, and that received message also had the problem. I looked at the html in my sent box and repeated deleted html to isolate the problem. It was a long message but I isolated it to the line with the mailto element. A copy of the html from my Sent box is in the attached file. When I "edit as new message" and send it to myself, the received message still has this problem.

Comment 1

[Francesco]

I can't reproduce this. I saved the attachment, renamed to .eml, imported into TB, displayed, clicked the link, compose window opens. All normal.
Oops, I was trying in 115. In 128, it's reproducible by just renaming the file to .eml and importing it.

Comment 2

[mozilla]

I was able to reproduce the problem doing what you described. I renamed the file to eml, then simply opened the file, which opened in Thunderbird. I then forwarded that file to myself. The forwarded file, in my inbox, had the same problem--clicking the link blanked out and froze the preview window. My Thunderbird version is 128.1. I just saw that 128.1.1 is available. I installed that and the problem remains.

Please let me know what else I can do. Thanks.

Comment 3

[mozilla]

One more experiment. I simply opened the emal file in thunderbird and clicked on the link without forwarding the message. The text of the message went blank, with no compose window. It did not blank out the preview window in my other folders, just the single message from the eml file.

Comment 4

[Francesco]

Alice, would you be able to find the regression?

Comment 5

[Alice0775 White]

(In reply to Francesco from comment #4)

Alice, would you be able to find the regression?

STR is unclear for me.

On TB 128.1.1esr Windows11.
When I clicked on the mailto link in the appropriate e-mail, the composing window opened as expected.
And the e-mail preview, folder pane and also thread pane are still responding (wfm).

Comment 6

[Francesco]

You've got the right steps. I'll test it again later. I dragged the message into a local folder. Did you do that? Or you used an IMAP folder? Or just opened the .eml? The latter might not fail.

Comment 7

[mozilla]

I ran some regression tests. In the regression window for 128, I dragged the eml file to the inbox. When I clicked the link, the message window went blank, there was no compose window, but it did not kill the preview window for other messages.

When I tried release 127 in the regression `window, everything worked, the compose window appeared.

Comment 8

[Alice0775 White]

(In reply to Francesco from comment #6)

You've got the right steps. I'll test it again later. I dragged the message into a local folder. Did you do that? Or you used an IMAP folder? Or just opened the .eml? The latter might not fail.

Okay
Save the attached Thunderbird message.txt as Thunderbird message.eml
Drag and drop the eml file to thread pane
Select the dropped message
Then click on please contact the Sanford general email link

Yes, Frozen.

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=4f734187ad1ec46542d704157611bac64030b3e6&tochange=25f09ad6335a5166fde773c81be1268147cda21f

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f5fee6066c60a5eb3209ca875245418081b00bdc&tochange=1a3eb3733a05c61fee90fbd2325013c0b6672817

Comment 9

[Francesco]

Thank you, Alice!

OK, editing the message body, this HTML still works: <a href="mailto:[e-mail]">please contact Sanford</a> and this doesn't <a href="mailto:[e-mail]"><strong>please contact Sanford</strong></a>. So the failure depends on whether the link text is wrapped in a <strong> tag.

Comment 10

[Francesco]

Attachment: Thunderbird message.eml

Simplified example.

Comment 11

[Alice0775 White]

When click the link, the debug build logs the following:

[Parent 16360, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x804B000A (NS_ERROR_MALFORMED_URI): file /builds/worker/checkouts/gecko/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp:1836
[Parent 16360, Main Thread] WARNING: NS_ENSURE_TRUE(mPumpingData) failed: file /builds/worker/checkouts/gecko/netwerk/base/nsBaseChannel.cpp:379
[Parent 16360, Main Thread] WARNING: NS_ENSURE_TRUE(mDoneSetup) failed: file /builds/worker/checkouts/gecko/editor/composer/nsEditingSession.cpp:1163
[Parent 16360, Main Thread] WARNING: NS_ENSURE_TRUE(mPumpingData) failed: file /builds/worker/checkouts/gecko/netwerk/base/nsBaseChannel.cpp:386
[Parent 16360, Main Thread] WARNING: 'aOwner->IsDiscarded()', file /builds/worker/workspace/obj-build/dist/include/mozilla/dom/SyncedContextInlines.h:95

Comment 12

[Alice0775 White]

Interestingly, the right-click menu Compose Message To worked as expected.

Comment 13

[Hartmut Welpmann [:welpy-cw]]

This works after a local backout of 248b14f0506708c405f6e50401182755a5fd09f0, so that seems to be the regressing bug.

If you click on the now broken link, debugging shows that nsInputStreamChannel::SetContentType is now being called where nsBaseChannel::SetContentType was called before, so net_ParseContentType() isn't executed.

Mike, do you have any insight on how to address this on the Thunderbird side?

Comment 14

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1914250 - Fix handling of mail links containing child elements. r=#thunderbird-reviewers

Comment 15

[Hartmut Welpmann [:welpy-cw]]

When MailLinkChild fails to recognize a 'mailto:' link, somehow MailtoProtocolHandler comes into play, which now interferes with the regression bug here. Maybe we can get rid of MailtoProtocolHandler altogether now, but I'm not sure if it's still being called anywhere else.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/efcb0d156201
Fix handling of mail links containing child elements. r=mkmelin

Comment 18

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

Sorry for the late response - I was on PTO last week. I'm glad you found a solution here!

Comment 20

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9420693 [details]
Bug 1914250 - Fix handling of mail links containing child elements. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1896929
User impact if declined: Message window freezes after clicking certain mailto: links
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): low

Comment 21

[Corey Bryant]

Comment on attachment 9420693 [details]
Bug 1914250 - Fix handling of mail links containing child elements. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 22

[Daniel Darnell [:dandarnell]]

Thunderbird 128.2.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/810002ac52d6