1897007 - Lando is marking landable stacks with closed parents as unlandable

Status: RESOLVED FIXED

(Conduit :: Lando, defect, P1)

Description

[Timothy Nikkel (:tnikkel)]

If I click land in lando I get

"Landing is Blocked
The requested set of revisions are not landable."

Not sure why, everything seems in order, nothing unusual or different from anything else I've landed.

Comment 1

[Connor Sheehan [:sheehan]]

I'm certain this is a regression from the landing checks refactor in bug 1888188. I have a hunch about what the issue is here, will need to investigate further.

Comment 2

[Timothy Nikkel (:tnikkel)]

The already landed patch that is at the base might be the issue.

Comment 3

[Erich Gubler [:ErichDonGubler]]

This also happened to me with https://lando.services.mozilla.com/D210094, in case it helps.

Comment 4

[Connor Sheehan [:sheehan]]

(In reply to Timothy Nikkel (:tnikkel) from comment #2)

The already landed patch that is at the base might be the issue.

Yes, this was my hunch, and after removing the parent revision, you are now able to land D210132. Working on a fix now.

Comment 5

[BMO Github Automation]

Attachment: [mozilla-conduit/lando-api] checks: only block assessment when revision is in landing path (Bug 1897007) (#410)

Comment 6

[BMO Github Automation]

Attachment: [mozilla-conduit/lando-api] checks: only apply warnings to assessments for relevant PHIDs (Bug 1897007) (#411)