Closed Bug 1897025 Opened 5 months ago Closed 5 months ago

[rustc 1.80] error: unexpected `cfg` condition value: `oom_with_alloc_error_panic`

Categories

(Core :: mozglue, defect)

Product:
Core
Component:
mozglue
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
128 Branch
Tracking Flags:
Tracking Status
firefox128 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Bug 1897025 - Change OOM hooks to use cfg() rather than a hidden feature.
48 bytes, text/x-phabricator-request
Details | Review 
[task 2024-05-15T23:12:58.966Z] 23:12:58    ERROR -  error: unexpected `cfg` condition value: `oom_with_hook`
[task 2024-05-15T23:12:58.966Z] 23:12:58     INFO -   --> mozglue/static/rust/lib.rs:5:13
[task 2024-05-15T23:12:58.966Z] 23:12:58     INFO -    |
[task 2024-05-15T23:12:58.966Z] 23:12:58     INFO -  5 | #![cfg_attr(feature = "oom_with_hook", feature(alloc_error_hook))]
[task 2024-05-15T23:12:58.966Z] 23:12:58     INFO -    |             ^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-15T23:12:58.966Z] 23:12:58     INFO -    |
[task 2024-05-15T23:12:58.966Z] 23:12:58     INFO -    = note: expected values for `feature` are: `moz_memory`
[task 2024-05-15T23:12:58.967Z] 23:12:58     INFO -    = help: consider adding `oom_with_hook` as a feature in `Cargo.toml`
[task 2024-05-15T23:12:58.967Z] 23:12:58     INFO -    = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-15T23:12:58.967Z] 23:12:58     INFO -    = note: `-D unexpected-cfgs` implied by `-D warnings`
[task 2024-05-15T23:12:58.967Z] 23:12:58     INFO -    = help: to override `-D warnings` add `#[allow(unexpected_cfgs)]`
[task 2024-05-15T23:12:58.967Z] 23:12:58    ERROR -  error: unexpected `cfg` condition value: `oom_with_alloc_error_panic`
[task 2024-05-15T23:12:58.967Z] 23:12:58     INFO -   --> mozglue/static/rust/lib.rs:6:13
[task 2024-05-15T23:12:58.967Z] 23:12:58     INFO -    |
[task 2024-05-15T23:12:58.968Z] 23:12:58     INFO -  6 | #![cfg_attr(feature = "oom_with_alloc_error_panic", feature(panic_oom_payload))]
[task 2024-05-15T23:12:58.968Z] 23:12:58     INFO -    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-15T23:12:58.968Z] 23:12:58     INFO -    |
[task 2024-05-15T23:12:58.968Z] 23:12:58     INFO -    = note: expected values for `feature` are: `moz_memory`
[task 2024-05-15T23:12:58.968Z] 23:12:58     INFO -    = help: consider adding `oom_with_alloc_error_panic` as a feature in `Cargo.toml`
[task 2024-05-15T23:12:58.968Z] 23:12:58     INFO -    = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-15T23:12:58.969Z] 23:12:58    ERROR -  error: unexpected `cfg` condition value: `oom_with_hook`
[task 2024-05-15T23:12:58.969Z] 23:12:58     INFO -     --> mozglue/static/rust/lib.rs:110:11
[task 2024-05-15T23:12:58.969Z] 23:12:58     INFO -      |
[task 2024-05-15T23:12:58.969Z] 23:12:58     INFO -  110 |     #[cfg(feature = "oom_with_hook")]
[task 2024-05-15T23:12:58.969Z] 23:12:58     INFO -      |           ^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-15T23:12:58.969Z] 23:12:58     INFO -      |
[task 2024-05-15T23:12:58.969Z] 23:12:58     INFO -      = note: expected values for `feature` are: `moz_memory`
[task 2024-05-15T23:12:58.969Z] 23:12:58     INFO -      = help: consider adding `oom_with_hook` as a feature in `Cargo.toml`
[task 2024-05-15T23:12:58.970Z] 23:12:58     INFO -      = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-15T23:12:58.970Z] 23:12:58    ERROR -  error: unexpected `cfg` condition value: `oom_with_hook`
[task 2024-05-15T23:12:58.970Z] 23:12:58     INFO -     --> mozglue/static/rust/lib.rs:112:11
[task 2024-05-15T23:12:58.970Z] 23:12:58     INFO -      |
[task 2024-05-15T23:12:58.970Z] 23:12:58     INFO -  112 |     #[cfg(feature = "oom_with_hook")]
[task 2024-05-15T23:12:58.970Z] 23:12:58     INFO -      |           ^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-15T23:12:58.970Z] 23:12:58     INFO -      |
[task 2024-05-15T23:12:58.970Z] 23:12:58     INFO -      = note: expected values for `feature` are: `moz_memory`
[task 2024-05-15T23:12:58.971Z] 23:12:58     INFO -      = help: consider adding `oom_with_hook` as a feature in `Cargo.toml`
[task 2024-05-15T23:12:58.971Z] 23:12:58     INFO -      = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-15T23:12:58.971Z] 23:12:58    ERROR -  error: unexpected `cfg` condition value: `oom_with_alloc_error_panic`
[task 2024-05-15T23:12:58.971Z] 23:12:58     INFO -     --> mozglue/static/rust/lib.rs:117:11
[task 2024-05-15T23:12:58.971Z] 23:12:58     INFO -      |
[task 2024-05-15T23:12:58.971Z] 23:12:58     INFO -  117 |     #[cfg(feature = "oom_with_alloc_error_panic")]
[task 2024-05-15T23:12:58.971Z] 23:12:58     INFO -      |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-15T23:12:58.971Z] 23:12:58     INFO -      |
[task 2024-05-15T23:12:58.972Z] 23:12:58     INFO -      = note: expected values for `feature` are: `moz_memory`
[task 2024-05-15T23:12:58.972Z] 23:12:58     INFO -      = help: consider adding `oom_with_alloc_error_panic` as a feature in `Cargo.toml`
[task 2024-05-15T23:12:58.972Z] 23:12:58     INFO -      = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-15T23:12:58.972Z] 23:12:58    ERROR -  error: unexpected `cfg` condition value: `oom_with_hook`
[task 2024-05-15T23:12:58.972Z] 23:12:58     INFO -     --> mozglue/static/rust/lib.rs:136:11
[task 2024-05-15T23:12:58.972Z] 23:12:58     INFO -      |
[task 2024-05-15T23:12:58.972Z] 23:12:58     INFO -  136 |     #[cfg(feature = "oom_with_hook")]
[task 2024-05-15T23:12:58.973Z] 23:12:58     INFO -      |           ^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-15T23:12:58.973Z] 23:12:58     INFO -      |
[task 2024-05-15T23:12:58.973Z] 23:12:58     INFO -      = note: expected values for `feature` are: `moz_memory`
[task 2024-05-15T23:12:58.973Z] 23:12:58     INFO -      = help: consider adding `oom_with_hook` as a feature in `Cargo.toml`
[task 2024-05-15T23:12:58.973Z] 23:12:58     INFO -      = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-15T23:12:58.973Z] 23:12:58    ERROR -  error: unexpected `cfg` condition value: `oom_with_alloc_error_panic`
[task 2024-05-15T23:12:58.973Z] 23:12:58     INFO -     --> mozglue/static/rust/lib.rs:124:15
[task 2024-05-15T23:12:58.974Z] 23:12:58     INFO -      |
[task 2024-05-15T23:12:58.974Z] 23:12:58     INFO -  124 |         #[cfg(feature = "oom_with_alloc_error_panic")]
[task 2024-05-15T23:12:58.974Z] 23:12:58     INFO -      |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-15T23:12:58.974Z] 23:12:58     INFO -      |
[task 2024-05-15T23:12:58.974Z] 23:12:58     INFO -      = note: expected values for `feature` are: `moz_memory`
[task 2024-05-15T23:12:58.974Z] 23:12:58     INFO -      = help: consider adding `oom_with_alloc_error_panic` as a feature in `Cargo.toml`
[task 2024-05-15T23:12:58.974Z] 23:12:58     INFO -      = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-15T23:12:58.975Z] 23:12:58    ERROR -  error: unexpected `cfg` condition value: `oom_with_alloc_error_panic`
[task 2024-05-15T23:12:58.975Z] 23:12:58     INFO -     --> mozglue/static/rust/lib.rs:128:19
[task 2024-05-15T23:12:58.975Z] 23:12:58     INFO -      |
[task 2024-05-15T23:12:58.975Z] 23:12:58     INFO -  128 |         #[cfg(not(feature = "oom_with_alloc_error_panic"))]
[task 2024-05-15T23:12:58.975Z] 23:12:58     INFO -      |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-15T23:12:58.975Z] 23:12:58     INFO -      |
[task 2024-05-15T23:12:58.975Z] 23:12:58     INFO -      = note: expected values for `feature` are: `moz_memory`
[task 2024-05-15T23:12:58.976Z] 23:12:58     INFO -      = help: consider adding `oom_with_alloc_error_panic` as a feature in `Cargo.toml`
[task 2024-05-15T23:12:58.976Z] 23:12:58     INFO -      = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-15T23:12:58.976Z] 23:12:58    ERROR -  error: could not compile `mozglue-static` (lib) due to 8 previous errors

Rustc/Cargo 1.80 introduces checks for uses of cfg() and features.
oom_with_hook and oom_with_alloc_error_panic are not meant to be
externally-enabled features, so they're better turned into cfg(),
which also now requires additional setup.

Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/ee555af7538d Change OOM hooks to use cfg() rather than a hidden feature. r=emilio

https://hg.mozilla.org/mozilla-central/rev/ee555af7538d

Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox128: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: