Update builders to rustc 1.80
Categories
(Firefox Build System :: Toolchains, task)
Tracking
(firefox132 fixed)
Tracking | Status | |
---|---|---|
firefox132 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert)
Attachments
(1 file)
Release date: July 25
Assignee | ||
Comment 1•3 months ago
|
||
Updated•3 months ago
|
Comment 3•3 months ago
•
|
||
Backed out for causing V-swr and SM bustages
Comment 5•3 months ago
|
||
It seems like cargo vendor
in 1.80
puts different contents in the Cargo.toml
files in third_party/rust
, resulting in failures like this one, where source-test-vendor-rust
reports that mach vendor rust
changes lots of files.
Running mach vendor rust
with a rustup override forcing 1.79 doesn't introduce any changes to current Mozilla Central, but running it again with 1.80 does. (I think it's necessary to delete your obj tree to see the effect of changing the version.)
I believe the diffs look like this:
diff --git a/third_party/rust/aa-stroke/.cargo-checksum.json b/third_party/rust/aa-stroke/.cargo-checksum.json
--- a/third_party/rust/aa-stroke/.cargo-checksum.json
+++ b/third_party/rust/aa-stroke/.cargo-checksum.json
@@ -1,1 +1,1 @@
-{"files":{".github/workflows/rust.yml":"6a9f1b122ea02367a2f1ff1fc7b9a728284ceb47fad12e1610cde9d760f4efc3","Cargo.toml":"f507cac11c3c26af28420d68ec3748a5453322d51ef1379a340fdd3b1c9b187a","README.md":"60b34cfa653114d5054009696df2ed2ea1d4926a6bc312d0cac4b84845c2beff","examples/simple.rs":"c196e79568fe4be31a08374aa451c70c9377db5428aef924a985e069c12ed91e","src/bezierflattener.rs":"c7183a850d51525db4389d5c0badb76e1d8c4110697bfa51ef746fda6a858bb9","src/c_bindings.rs":"06225ddd132ae959eda1b445f4e375cead4d8e135c5cba81e828815fe6a5e88b","src/lib.rs":"3009746efe5f6753cd999258077a4baea30a740190e7a8ccaec0d78f4719fdfb","src/tri_rasterize.rs":"fb6f595ab9340d8ea6429b41638c378bbd772c8e4d8f7793e225624c12cd3a21"},"package":null}
\ No newline at end of file
+{"files":{".github/workflows/rust.yml":"6a9f1b122ea02367a2f1ff1fc7b9a728284ceb47fad12e1610cde9d760f4efc3","Cargo.toml":"8462d3a039a219717eca97fd03a9a57d77ffd182837d32c2aec126588b6ab281","README.md":"60b34cfa653114d5054009696df2ed2ea1d4926a6bc312d0cac4b84845c2beff","examples/simple.rs":"c196e79568fe4be31a08374aa451c70c9377db5428aef924a985e069c12ed91e","src/bezierflattener.rs":"c7183a850d51525db4389d5c0badb76e1d8c4110697bfa51ef746fda6a858bb9","src/c_bindings.rs":"06225ddd132ae959eda1b445f4e375cead4d8e135c5cba81e828815fe6a5e88b","src/lib.rs":"3009746efe5f6753cd999258077a4baea30a740190e7a8ccaec0d78f4719fdfb","src/tri_rasterize.rs":"fb6f595ab9340d8ea6429b41638c378bbd772c8e4d8f7793e225624c12cd3a21"},"package":null}
\ No newline at end of file
diff --git a/third_party/rust/aa-stroke/Cargo.toml b/third_party/rust/aa-stroke/Cargo.toml
--- a/third_party/rust/aa-stroke/Cargo.toml
+++ b/third_party/rust/aa-stroke/Cargo.toml
@@ -9,13 +9,30 @@
# will likely look very different (and much more reasonable).
# See Cargo.toml.orig for the original contents.
+bin = []
+test = []
+bench = []
+
[package]
edition = "2021"
name = "aa-stroke"
version = "0.1.0"
+build = false
+autobins = false
+autoexamples = false
+autotests = false
+autobenches = false
readme = "README.md"
license = "MIT"
+[lib]
+name = "aa_stroke"
+path = "src/lib.rs"
+
+[[example]]
+name = "simple"
+path = "examples/simple.rs"
+
[dependencies]
euclid = "0.22.7"
Updated•3 months ago
|
Comment 6•2 months ago
|
||
There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:glandium, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
Assignee | ||
Updated•2 months ago
|
Assignee | ||
Updated•2 months ago
|
Comment 8•2 months ago
|
||
Backed out for causing linting vendor failure.
[task 2024-09-02T23:18:15.523Z] Vendoring zip v2.1.3 (/builds/worker/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zip-2.1.3) to /builds/worker/checkouts/gecko/third_party/rust/zip
[task 2024-09-02T23:18:15.538Z] To use vendored sources, add this to your .cargo/config.toml for this project:
[task 2024-09-02T23:18:15.538Z]
[task 2024-09-02T23:18:25.351Z] File was modified by vendor: third_party/rust/aa-stroke/.cargo-checksum.json
[task 2024-09-02T23:18:25.351Z] File was modified by vendor: third_party/rust/aa-stroke/Cargo.toml
[task 2024-09-02T23:18:25.351Z] File was modified by vendor: third_party/rust/any_all_workaround/.cargo-checksum.json
[task 2024-09-02T23:18:25.351Z] File was modified by vendor: third_party/rust/any_all_workaround/Cargo.toml
[task 2024-09-02T23:18:25.351Z] File was modified by vendor: third_party/rust/audioipc2-client/.cargo-checksum.json
[task 2024-09-02T23:18:25.351Z] File was modified by vendor: third_party/rust/audioipc2-client/Cargo.toml
[task 2024-09-02T23:18:25.351Z] File was modified by vendor: third_party/rust/audioipc2-server/.cargo-checksum.json
[task 2024-09-02T23:18:25.351Z] File was modified by vendor: third_party/rust/audioipc2-server/Cargo.toml
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/audioipc2/.cargo-checksum.json
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/audioipc2/Cargo.toml
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/chardetng/.cargo-checksum.json
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/chardetng/Cargo.toml
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/chardetng_c/.cargo-checksum.json
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/chardetng_c/Cargo.toml
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/coreaudio-sys-utils/.cargo-checksum.json
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/coreaudio-sys-utils/Cargo.toml
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/coremidi/.cargo-checksum.json
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/coremidi/Cargo.toml
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/cose/.cargo-checksum.json
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/cose/Cargo.toml
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/cubeb-coreaudio/.cargo-checksum.json
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/cubeb-coreaudio/Cargo.toml
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/cubeb-pulse/.cargo-checksum.json
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/cubeb-pulse/Cargo.toml
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/error-support-macros/.cargo-checksum.json
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/error-support-macros/Cargo.toml
[task 2024-09-02T23:18:25.352Z] File was modified by vendor: third_party/rust/error-support/.cargo-checksum.json
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/error-support/Cargo.toml
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/gpu-descriptor-types/.cargo-checksum.json
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/gpu-descriptor-types/Cargo.toml
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/gpu-descriptor/.cargo-checksum.json
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/gpu-descriptor/Cargo.toml
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/interrupt-support/.cargo-checksum.json
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/interrupt-support/Cargo.toml
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus-ast/.cargo-checksum.json
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus-ast/Cargo.toml
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus-emitter/.cargo-checksum.json
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus-emitter/Cargo.toml
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus-generated-parser/.cargo-checksum.json
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus-generated-parser/Cargo.toml
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus-json-log/.cargo-checksum.json
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus-json-log/Cargo.toml
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus-parser/.cargo-checksum.json
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus-parser/Cargo.toml
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus-scope/.cargo-checksum.json
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus-scope/Cargo.toml
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus-stencil/.cargo-checksum.json
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus-stencil/Cargo.toml
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus/.cargo-checksum.json
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/jsparagus/Cargo.toml
[task 2024-09-02T23:18:25.353Z] File was modified by vendor: third_party/rust/mapped_hyph/.cargo-checksum.json
[task 2024-09-02T23:18:25.354Z] File was modified by vendor: third_party/rust/mapped_hyph/Cargo.toml
[task 2024-09-02T23:18:25.354Z] File was modified by vendor: third_party/rust/midir/.cargo-checksum.json
[task 2024-09-02T23:18:25.354Z] File was modified by vendor: third_party/rust/midir/Cargo.toml
[task 2024-09-02T23:18:25.354Z] File was modified by vendor: third_party/rust/mp4parse/.cargo-checksum.json
[task 2024-09-02T23:18:25.354Z] File was modified by vendor: third_party/rust/mp4parse/Cargo.toml
[task 2024-09-02T23:18:25.354Z] File was modified by vendor: third_party/rust/mp4parse_capi/.cargo-checksum.json
[task 2024-09-02T23:18:25.354Z] File was modified by vendor: third_party/rust/mp4parse_capi/Cargo.toml
[task 2024-09-02T23:18:25.354Z] File was modified by vendor: third_party/rust/naga/.cargo-checksum.json
[task 2024-09-02T23:18:25.354Z] File was modified by vendor: third_party/rust/naga/Cargo.toml
[task 2024-09-02T23:18:25.354Z] File was modified by vendor: third_party/rust/neqo-bin/.cargo-checksum.json
[task 2024-09-02T23:18:25.354Z] File was modified by vendor: third_party/rust/neqo-bin/Cargo.toml
[task 2024-09-02T23:18:25.355Z] File was modified by vendor: third_party/rust/neqo-common/.cargo-checksum.json
[task 2024-09-02T23:18:25.355Z] File was modified by vendor: third_party/rust/neqo-common/Cargo.toml
[task 2024-09-02T23:18:25.355Z] File was modified by vendor: third_party/rust/neqo-crypto/.cargo-checksum.json
[task 2024-09-02T23:18:25.355Z] File was modified by vendor: third_party/rust/neqo-crypto/Cargo.toml
[task 2024-09-02T23:18:25.355Z] File was modified by vendor: third_party/rust/neqo-http3/.cargo-checksum.json
[task 2024-09-02T23:18:25.355Z] File was modified by vendor: third_party/rust/neqo-http3/Cargo.toml
[task 2024-09-02T23:18:25.355Z] File was modified by vendor: third_party/rust/neqo-qpack/.cargo-checksum.json
[task 2024-09-02T23:18:25.356Z] File was modified by vendor: third_party/rust/neqo-qpack/Cargo.toml
[task 2024-09-02T23:18:25.356Z] File was modified by vendor: third_party/rust/neqo-transport/.cargo-checksum.json
[task 2024-09-02T23:18:25.356Z] File was modified by vendor: third_party/rust/neqo-transport/Cargo.toml
[task 2024-09-02T23:18:25.356Z] File was modified by vendor: third_party/rust/neqo-udp/.cargo-checksum.json
[task 2024-09-02T23:18:25.356Z] File was modified by vendor: third_party/rust/neqo-udp/Cargo.toml
[task 2024-09-02T23:18:25.356Z] File was modified by vendor: third_party/rust/nss_build_common/.cargo-checksum.json
[task 2024-09-02T23:18:25.356Z] File was modified by vendor: third_party/rust/nss_build_common/Cargo.toml
[task 2024-09-02T23:18:25.357Z] File was modified by vendor: third_party/rust/payload-support/.cargo-checksum.json
[task 2024-09-02T23:18:25.357Z] File was modified by vendor: third_party/rust/payload-support/Cargo.toml
[task 2024-09-02T23:18:25.357Z] File was modified by vendor: third_party/rust/pulse-ffi/.cargo-checksum.json
[task 2024-09-02T23:18:25.357Z] File was modified by vendor: third_party/rust/pulse-ffi/Cargo.toml
[task 2024-09-02T23:18:25.357Z] File was modified by vendor: third_party/rust/pulse/.cargo-checksum.json
[task 2024-09-02T23:18:25.357Z] File was modified by vendor: third_party/rust/pulse/Cargo.toml
[task 2024-09-02T23:18:25.357Z] File was modified by vendor: third_party/rust/relevancy/.cargo-checksum.json
[task 2024-09-02T23:18:25.358Z] File was modified by vendor: third_party/rust/relevancy/Cargo.toml
[task 2024-09-02T23:18:25.358Z] File was modified by vendor: third_party/rust/remote_settings/.cargo-checksum.json
[task 2024-09-02T23:18:25.358Z] File was modified by vendor: third_party/rust/remote_settings/Cargo.toml
[task 2024-09-02T23:18:25.358Z] File was modified by vendor: third_party/rust/sql-support/.cargo-checksum.json
[task 2024-09-02T23:18:25.358Z] File was modified by vendor: third_party/rust/sql-support/Cargo.toml
[task 2024-09-02T23:18:25.358Z] File was modified by vendor: third_party/rust/suggest/.cargo-checksum.json
[task 2024-09-02T23:18:25.358Z] File was modified by vendor: third_party/rust/suggest/Cargo.toml
[task 2024-09-02T23:18:25.359Z] File was modified by vendor: third_party/rust/sync-guid/.cargo-checksum.json
[task 2024-09-02T23:18:25.359Z] File was modified by vendor: third_party/rust/sync-guid/Cargo.toml
[task 2024-09-02T23:18:25.359Z] File was modified by vendor: third_party/rust/sync15/.cargo-checksum.json
[task 2024-09-02T23:18:25.359Z] File was modified by vendor: third_party/rust/sync15/Cargo.toml
[task 2024-09-02T23:18:25.359Z] File was modified by vendor: third_party/rust/tabs/.cargo-checksum.json
[task 2024-09-02T23:18:25.359Z] File was modified by vendor: third_party/rust/tabs/Cargo.toml
[task 2024-09-02T23:18:25.359Z] File was modified by vendor: third_party/rust/types/.cargo-checksum.json
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/types/Cargo.toml
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/unicode-bidi/.cargo-checksum.json
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/unicode-bidi/Cargo.toml
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/viaduct/.cargo-checksum.json
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/viaduct/Cargo.toml
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/webext-storage/.cargo-checksum.json
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/webext-storage/Cargo.toml
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/wgpu-core/.cargo-checksum.json
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/wgpu-core/Cargo.toml
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/wgpu-hal/.cargo-checksum.json
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/wgpu-hal/Cargo.toml
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/wgpu-types/.cargo-checksum.json
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/wgpu-types/Cargo.toml
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/wpf-gpu-raster/.cargo-checksum.json
[task 2024-09-02T23:18:25.360Z] File was modified by vendor: third_party/rust/wpf-gpu-raster/Cargo.toml
[task 2024-09-02T23:18:25.360Z] Creating default state directory: /builds/worker/.mozbuild
[task 2024-09-02T23:18:25.361Z] Running "pip check" to verify compatibility between the system Python and the "mach" site.
[task 2024-09-02T23:18:25.361Z] Creating local state directory: /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69
[task 2024-09-02T23:18:25.361Z] Running "pip check" to verify compatibility between the system Python and the "common" site.
[task 2024-09-02T23:18:25.361Z] Errors occured; new rust crates were not vendored.
[taskcluster 2024-09-02 23:18:26.247Z] === Task Finished ===
[taskcluster 2024-09-02 23:18:26.502Z] Unsuccessful task run with exit code: 1 completed in 281.223 seconds
Assignee | ||
Updated•2 months ago
|
Comment 10•2 months ago
|
||
Comment 11•2 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c49e334c10e1
https://hg.mozilla.org/mozilla-central/rev/a9effb068f72
Comment 12•2 months ago
|
||
(In reply to Pulsebot from comment #7)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/f970c5107aa7
Update builders to rustc 1.80.1. r=firefox-build-system-reviewers,ahochheiden
Perfherder has detected a build_metrics performance change from push f970c5107aa74cfe045a14dfed8fa2685c1f58e2.
Improvements:
Ratio | Test | Platform | Options | Absolute values (old vs new) |
---|---|---|---|---|
0.21% | installer size | osx-aarch64-shippable | aarch64 nightly | 93,293,643.24 -> 93,101,460.17 |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with ./mach try perf --alert 1982
For more information on performance sheriffing please see our FAQ.
Description
•