1897037 - [rustc 1.80] error: unexpected `cfg` condition value: `cargo-clippy`

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Mike Hommey [:glandium]]

[task 2024-05-15T23:12:58.786Z] 23:12:58    ERROR -  error: unexpected `cfg` condition value: `cargo-clippy`
[task 2024-05-15T23:12:58.786Z] 23:12:58     INFO -    --> gfx/wr/webrender_api/src/lib.rs:15:13
[task 2024-05-15T23:12:58.786Z] 23:12:58     INFO -     |
[task 2024-05-15T23:12:58.787Z] 23:12:58     INFO -  15 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::float_cmp, clippy::too_many_arguments))]
[task 2024-05-15T23:12:58.787Z] 23:12:58     INFO -     |             ^^^^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-15T23:12:58.787Z] 23:12:58     INFO -     |
[task 2024-05-15T23:12:58.787Z] 23:12:58     INFO -     = note: expected values for `feature` are: `deserialize`, `display_list_stats`, `nightly`, `serialize`
[task 2024-05-15T23:12:58.787Z] 23:12:58     INFO -     = help: consider adding `cargo-clippy` as a feature in `Cargo.toml`
[task 2024-05-15T23:12:58.787Z] 23:12:58     INFO -     = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-15T23:12:58.787Z] 23:12:58     INFO -     = note: `-D unexpected-cfgs` implied by `-D warnings`
[task 2024-05-15T23:12:58.788Z] 23:12:58     INFO -     = help: to override `-D warnings` add `#[allow(unexpected_cfgs)]`
[task 2024-05-15T23:12:58.788Z] 23:12:58    ERROR -  error: unexpected `cfg` condition value: `cargo-clippy`
[task 2024-05-15T23:12:58.788Z] 23:12:58     INFO -    --> gfx/wr/webrender_api/src/lib.rs:16:13
[task 2024-05-15T23:12:58.788Z] 23:12:58     INFO -     |
[task 2024-05-15T23:12:58.788Z] 23:12:58     INFO -  16 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::unreadable_literal, clippy::new_without_default))]
[task 2024-05-15T23:12:58.788Z] 23:12:58     INFO -     |             ^^^^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-15T23:12:58.788Z] 23:12:58     INFO -     |
[task 2024-05-15T23:12:58.788Z] 23:12:58     INFO -     = note: expected values for `feature` are: `deserialize`, `display_list_stats`, `nightly`, `serialize`
[task 2024-05-15T23:12:58.789Z] 23:12:58     INFO -     = help: consider adding `cargo-clippy` as a feature in `Cargo.toml`
[task 2024-05-15T23:12:58.789Z] 23:12:58     INFO -     = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-15T23:12:58.789Z] 23:12:58    ERROR -  error: unexpected `cfg` condition value: `cargo-clippy`
[task 2024-05-15T23:12:58.789Z] 23:12:58     INFO -    --> gfx/wr/webrender_api/src/color.rs:99:12
[task 2024-05-15T23:12:58.789Z] 23:12:58     INFO -     |
[task 2024-05-15T23:12:58.789Z] 23:12:58     INFO -  99 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::derive_hash_xor_eq))]
[task 2024-05-15T23:12:58.789Z] 23:12:58     INFO -     |            ^^^^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-15T23:12:58.789Z] 23:12:58     INFO -     |
[task 2024-05-15T23:12:58.790Z] 23:12:58     INFO -     = note: expected values for `feature` are: `deserialize`, `display_list_stats`, `nightly`, `serialize`
[task 2024-05-15T23:12:58.790Z] 23:12:58     INFO -     = help: consider adding `cargo-clippy` as a feature in `Cargo.toml`
[task 2024-05-15T23:12:58.790Z] 23:12:58     INFO -     = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-15T23:12:58.790Z] 23:12:58    ERROR -  error: unexpected `cfg` condition value: `cargo-clippy`
[task 2024-05-15T23:12:58.790Z] 23:12:58     INFO -     --> gfx/wr/webrender_api/src/font.rs:434:12
[task 2024-05-15T23:12:58.790Z] 23:12:58     INFO -      |
[task 2024-05-15T23:12:58.791Z] 23:12:58     INFO -  434 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::derive_hash_xor_eq))]
[task 2024-05-15T23:12:58.791Z] 23:12:58     INFO -      |            ^^^^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-15T23:12:58.791Z] 23:12:58     INFO -      |
[task 2024-05-15T23:12:58.791Z] 23:12:58     INFO -      = note: expected values for `feature` are: `deserialize`, `display_list_stats`, `nightly`, `serialize`
[task 2024-05-15T23:12:58.791Z] 23:12:58     INFO -      = help: consider adding `cargo-clippy` as a feature in `Cargo.toml`
[task 2024-05-15T23:12:58.791Z] 23:12:58     INFO -      = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-15T23:12:58.791Z] 23:12:58    ERROR -  error: could not compile `webrender_api` (lib) due to 4 previous errors

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1897037 - Remove cargo-clippy feature check.

The #[cfg_attr(feature = "cargo-clippy", allow(...))] pattern was
necessary back when the clippy warnings weren't namespaced.

That's not necessary anymore.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14944af4a6fa
Remove cargo-clippy feature check. r=gfx-reviewers,nical

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/14944af4a6fa