1897041 - [rustc 1.80] error: unexpected `cfg` condition value: `serialize`

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Mike Hommey [:glandium]]

[task 2024-05-16T01:02:02.495Z] 01:02:02    ERROR -  error: unexpected `cfg` condition value: `serialize`
[task 2024-05-16T01:02:02.495Z] 01:02:02     INFO -    --> gfx/wr/webrender/src/render_backend.rs:59:7
[task 2024-05-16T01:02:02.495Z] 01:02:02     INFO -     |
[task 2024-05-16T01:02:02.495Z] 01:02:02     INFO -  59 | #[cfg(feature = "serialize")]
[task 2024-05-16T01:02:02.495Z] 01:02:02     INFO -     |       ^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-16T01:02:02.496Z] 01:02:02     INFO -     |
[task 2024-05-16T01:02:02.496Z] 01:02:02     INFO -     = note: expected values for `feature` are: `capture`, `default`, `display_list_stats`, `dynamic_freetype`, `firefox-on-glean`, `gecko`, `glean`, `leak_checks`, `png`, `profiler`, `replay`, `ron`, `serde`, `serialize_program`, `static_freetype`, `sw_compositor`, `swgl`
[task 2024-05-16T01:02:02.496Z] 01:02:02     INFO -     = help: consider adding `serialize` as a feature in `Cargo.toml`
[task 2024-05-16T01:02:02.496Z] 01:02:02     INFO -     = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-16T01:02:02.496Z] 01:02:02    ERROR -  error: unexpected `cfg` condition name: `features`
[task 2024-05-16T01:02:02.496Z] 01:02:02     INFO -      --> gfx/wr/webrender/src/resource_cache.rs:1741:15
[task 2024-05-16T01:02:02.496Z] 01:02:02     INFO -       |
[task 2024-05-16T01:02:02.496Z] 01:02:02     INFO -  1741 |         #[cfg(features="leak_checks")]
[task 2024-05-16T01:02:02.497Z] 01:02:02     INFO -       |               ^^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-16T01:02:02.497Z] 01:02:02     INFO -       |
[task 2024-05-16T01:02:02.497Z] 01:02:02     INFO -       = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-16T01:02:02.497Z] 01:02:02     INFO -  help: there is a config with a similar name and value
[task 2024-05-16T01:02:02.497Z] 01:02:02     INFO -       |
[task 2024-05-16T01:02:02.497Z] 01:02:02     INFO -  1741 |         #[cfg(feature="leak_checks")]
[task 2024-05-16T01:02:02.497Z] 01:02:02     INFO -       |               ~~~~~~~
[task 2024-05-16T01:02:02.497Z] 01:02:02    ERROR -  error: unexpected `cfg` condition name: `features`
[task 2024-05-16T01:02:02.498Z] 01:02:02     INFO -      --> gfx/wr/webrender/src/resource_cache.rs:1743:19
[task 2024-05-16T01:02:02.498Z] 01:02:02     INFO -       |
[task 2024-05-16T01:02:02.498Z] 01:02:02     INFO -  1743 |         #[cfg(not(features="leak_checks"))]
[task 2024-05-16T01:02:02.498Z] 01:02:02     INFO -       |                   ^^^^^^^^^^^^^^^^^^^^^^
[task 2024-05-16T01:02:02.498Z] 01:02:02     INFO -       |
[task 2024-05-16T01:02:02.498Z] 01:02:02     INFO -       = note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
[task 2024-05-16T01:02:02.498Z] 01:02:02     INFO -  help: there is a config with a similar name and value
[task 2024-05-16T01:02:02.498Z] 01:02:02     INFO -       |
[task 2024-05-16T01:02:02.498Z] 01:02:02     INFO -  1743 |         #[cfg(not(feature="leak_checks"))]
[task 2024-05-16T01:02:02.499Z] 01:02:02     INFO -       |                   ~~~~~~~

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1897041 - Fix feature checks in webrender.

There was a typo features/feature, and the serialize feature doesn't
exist, while the Serialize and Deserialize traits are used with
different features.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b198d534513
Fix feature checks in webrender. r=gfx-reviewers,nical

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3b198d534513