1897109 - Some tests are setting trimHttps = false but they should run regardless

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Marco Bonardo [:mak]]

There's a few tests that are disabling trimHttps, but it would be better if they'd run regardless.
https://searchfox.org/mozilla-central/source/browser/components/urlbar/tests/browser/browser_autocomplete_edit_completed.js#9
https://searchfox.org/mozilla-central/source/browser/components/urlbar/tests/browser/browser_autoFill_trimURLs.js#13
https://searchfox.org/mozilla-central/source/browser/components/urlbar/tests/browser/browser_caret_position.js#12
https://searchfox.org/mozilla-central/source/browser/components/urlbar/tests/browser/browser_editAndEnterWithSlowQuery.js#33

And I will fix https://searchfox.org/mozilla-central/source/browser/components/urlbar/tests/browser/browser_UrlbarInput_overflow.js#99 in Bug 1862404

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1897109 - Urlbar tests should run also with trimHttps enabled. r=jteow

Note this patch changes the urlbar behavior regarding the value put into the
input when a result is selected with the keyboard. We won't trim the value
anymore in most cases.
Trimming makes too easy for the user to transform https into http, and
in general it makes harder to predict the result after editing or copying from
the urlbar after selecting a result.
This resembles the behavior of other mainstream browsers.
The only special case where we still trim the value, is when we add http to a
schemeless user typed value, as we may be using https first, then showing
http would be confusing. Though if trimming the url may transform it into a
search, we still don't trim and accept showing a potentially confusing protocol.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b03179b0220e
Urlbar tests should run also with trimHttps enabled. r=jteow

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b03179b0220e