1897181 - VideoEncoder: macOS support

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, defect, P1)

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1897181 - Handle the fact that VideoToolbox h264 encoder doesn't support CBR. r?chunmin

Unfortunately this is required for tests to pass.

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1897181 - Let the storage class of the RefPtr be inferred to fix UAF. r?chunmin

If we don't do this, the RefPtr isn't addrefed correctly and the
ProcessReconfigure method sees freed data for the change list.

Depends on D210693

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1897181 - When attempting an encoder reconfiguration on the fly on macOS, all configuration change must succeed for the reconfiguration considered successful. r?chunmin

Depends on D210694

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1897181 - Allow draining a VideoToolbox encoder multiple times. r?chunmin

Depends on D210695

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1897181 - When reconfiguring an encoder on the fly succeeds, set the EncoderAgent's state to Configured. r?chunmin

Depends on D210696

Comment 6

[Paul Adenot (:padenot)]

Attachment: Bug 1897181 - Adjust expectation for WebCodecs WPT on macOS for VideoEncoder. r?chunmin

Depends on D210697

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f1417ad8c48
Handle the fact that VideoToolbox h264 encoder doesn't support CBR. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/38e91d70fc2e
Let the storage class of the RefPtr be inferred to fix UAF. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/069f83f502f6
When attempting an encoder reconfiguration on the fly on macOS, all configuration change must succeed for the reconfiguration considered successful. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a1527c964edd
Allow draining a VideoToolbox encoder multiple times. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/0fe2f70244ca
When reconfiguring an encoder on the fly succeeds, set the EncoderAgent's state to Configured. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/702d8373d765
Adjust expectation for WebCodecs WPT on macOS for VideoEncoder. r=chunmin

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5f1417ad8c48
https://hg.mozilla.org/mozilla-central/rev/38e91d70fc2e
https://hg.mozilla.org/mozilla-central/rev/069f83f502f6
https://hg.mozilla.org/mozilla-central/rev/a1527c964edd
https://hg.mozilla.org/mozilla-central/rev/0fe2f70244ca
https://hg.mozilla.org/mozilla-central/rev/702d8373d765

Comment 9

[Noemi Erli[:noemi_erli]]

Backed out 12 changesets (Bug 1897481, Bug 1897181) for causing failures in temporal-svc-encoding.https.any.html CLOSED TREE

This is permafailing on central: https://treeherder.mozilla.org/jobs?repo=mozilla-central&group_state=expanded&collapsedPushes=842382&selectedTaskRun=e26kVGBjRq-MDnZ-vmajkg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=fd0f25542804074c0a38ba6c7f273a36bf658127&searchStr=os%2Cx%2C11%2Cwebrender%2Cshippable%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-macosx1100-64-shippable-qr%2Fopt-web-platform-tests-webcodecs%2Ccodecs

Log: https://treeherder.mozilla.org/logviewer?job_id=460249549&repo=mozilla-central&lineNumber=1107

Backout: https://hg.mozilla.org/integration/autoland/rev/5a08862cb26503c5d3515352d4c166c162a5d247

Comment 10

[Cristian Tuns]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/b05a24f15850

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3c4a93ef5e0
Handle the fact that VideoToolbox h264 encoder doesn't support CBR. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/4af28589bef7
Let the storage class of the RefPtr be inferred to fix UAF. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/383031890249
When attempting an encoder reconfiguration on the fly on macOS, all configuration change must succeed for the reconfiguration considered successful. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a8a7d735f315
Allow draining a VideoToolbox encoder multiple times. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/4c7e4f90699b
When reconfiguring an encoder on the fly succeeds, set the EncoderAgent's state to Configured. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a18a7b71409d
Adjust expectation for WebCodecs WPT on macOS for VideoEncoder. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/5514d4e14cdf
1897481: apply code formatting via Lando

Comment 12

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/5a08862cb265

Comment 13

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/75d54982d60d6b0fc1794135d0079409dc975228

Push with failures

Failure log -> /builds/worker/checkouts/gecko/dom/media/platforms/apple/AppleUtils.h:20:12: fatal error: 'nsCocoaFeatures.h' file not found

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92fb1d68c2dc
Handle the fact that VideoToolbox h264 encoder doesn't support CBR. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/b4bd4c49292f
Let the storage class of the RefPtr be inferred to fix UAF. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/35f2d644c461
When attempting an encoder reconfiguration on the fly on macOS, all configuration change must succeed for the reconfiguration considered successful. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/20725aacadc4
Allow draining a VideoToolbox encoder multiple times. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/2aa3204fca43
When reconfiguring an encoder on the fly succeeds, set the EncoderAgent's state to Configured. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/638c6d3d0717
Adjust expectation for WebCodecs WPT on macOS for VideoEncoder. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/883277d55a14
1897481: apply code formatting via Lando

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/92fb1d68c2dc
https://hg.mozilla.org/mozilla-central/rev/b4bd4c49292f
https://hg.mozilla.org/mozilla-central/rev/35f2d644c461
https://hg.mozilla.org/mozilla-central/rev/20725aacadc4
https://hg.mozilla.org/mozilla-central/rev/2aa3204fca43
https://hg.mozilla.org/mozilla-central/rev/638c6d3d0717
https://hg.mozilla.org/mozilla-central/rev/883277d55a14