1897481 - Implement h264 svc on macOS

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, enhancement)

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1897481 - Implement H264 L1T2 SVC encoding on macOS / VideoToolbox. r?chunmin

Depends on D210698

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1897481 - Reverse conditional to provide better logging. r?chunmin

When a frame is dropped by the encoder, because it is set to operate in
real-time, the flag is set and the buffer is nullptr, but the flag provide
better information.

Depends on D210912

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1897481 - Fix typo in AppleVTEncoder.cpp. r?chunmin

Depends on D210914

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1897481 - Explicitly use the format specified at configuration time when outputing h264 packets. r?chunmin

Depends on D210915

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1897481 - Update WPT expectations. r?chunmin

Depends on D210916

Comment 6

[Paul Adenot (:padenot)]

Attachment: Bug 1897481 - Properly implement support detection for h264 SVC on macOS and mark WPTs expectations appropriately. r?chunmin

Depends on D210919

Comment 8

[Paul Adenot (:padenot)]

Attachment: Bug 1897481 - Implement H264 SVC in WMFEncoderModule. r?jolin,chunmin

Comment 9

[Phabricator Automation]

Comment on attachment 9403811 [details]
Bug 1897481 - Implement H264 SVC in WMFEncoderModule. r?jolin,chunmin

Revision D211573 was moved to bug 1872879. Setting attachment 9403811 [details] to obsolete.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Should it be mentioned in the release notes?

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/126b9ba6b909
Implement H264 L1T2 SVC encoding on macOS / VideoToolbox. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a91b229f4fad
Reverse conditional to provide better logging. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/97b269d25105
Fix typo in AppleVTEncoder.cpp. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/4ca12a66de94
Explicitly use the format specified at configuration time when outputing h264 packets. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/412897e06226
Update WPT expectations. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/2e4e87506c23
Properly implement support detection for h264 SVC on macOS and mark WPTs expectations appropriately. r=chunmin

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/126b9ba6b909
https://hg.mozilla.org/mozilla-central/rev/a91b229f4fad
https://hg.mozilla.org/mozilla-central/rev/97b269d25105
https://hg.mozilla.org/mozilla-central/rev/4ca12a66de94
https://hg.mozilla.org/mozilla-central/rev/412897e06226
https://hg.mozilla.org/mozilla-central/rev/2e4e87506c23

Comment 13

[Noemi Erli[:noemi_erli]]

Backed out 12 changesets (Bug 1897481, Bug 1897181) for causing failures in temporal-svc-encoding.https.any.html CLOSED TREE

This is permafailing on central: https://treeherder.mozilla.org/jobs?repo=mozilla-central&group_state=expanded&collapsedPushes=842382&selectedTaskRun=e26kVGBjRq-MDnZ-vmajkg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=fd0f25542804074c0a38ba6c7f273a36bf658127&searchStr=os%2Cx%2C11%2Cwebrender%2Cshippable%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-macosx1100-64-shippable-qr%2Fopt-web-platform-tests-webcodecs%2Ccodecs

Log: https://treeherder.mozilla.org/logviewer?job_id=460249549&repo=mozilla-central&lineNumber=1107

Backout: https://hg.mozilla.org/integration/autoland/rev/5a08862cb26503c5d3515352d4c166c162a5d247

Comment 14

[Cristian Tuns]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/b05a24f15850

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cef425ff926e
Implement H264 L1T2 SVC encoding on macOS / VideoToolbox. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/54aa09e3679a
Reverse conditional to provide better logging. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/ccd7eb95aef0
Fix typo in AppleVTEncoder.cpp. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/60ed5cd94bd0
Explicitly use the format specified at configuration time when outputing h264 packets. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/8ee4a8a52638
Update WPT expectations. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/5eac176247ce
Properly implement support detection for h264 SVC on macOS and mark WPTs expectations appropriately. r=chunmin

Comment 16

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/5a08862cb265

Comment 17

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/75d54982d60d6b0fc1794135d0079409dc975228

Push with failures

Failure log -> /builds/worker/checkouts/gecko/dom/media/platforms/apple/AppleUtils.h:20:12: fatal error: 'nsCocoaFeatures.h' file not found

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

Paul, once this lands can you nominate it for a release note? Thanks!
More info at: https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Comment 19

[Paul Adenot (:padenot)]

(In reply to Liz Henry (:lizzard) (relman/hg->git project) from comment #18)

Paul, once this lands can you nominate it for a release note? Thanks!
More info at: https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

We'll do a release note about Web Codecs instead, the wider projects this is part of: https://bugzilla.mozilla.org/show_bug.cgi?id=webcodecs

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2a3e9ccbc4d
Implement H264 L1T2 SVC encoding on macOS / VideoToolbox. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/b6c913739ec1
Reverse conditional to provide better logging. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/7d09ffbe1be0
Fix typo in AppleVTEncoder.cpp. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/5ce06ab06fc7
Explicitly use the format specified at configuration time when outputing h264 packets. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/cc45d9719994
Update WPT expectations. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/e33f0c927b0b
Properly implement support detection for h264 SVC on macOS and mark WPTs expectations appropriately. r=chunmin

Comment 21

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b2a3e9ccbc4d
https://hg.mozilla.org/mozilla-central/rev/b6c913739ec1
https://hg.mozilla.org/mozilla-central/rev/7d09ffbe1be0
https://hg.mozilla.org/mozilla-central/rev/5ce06ab06fc7
https://hg.mozilla.org/mozilla-central/rev/cc45d9719994
https://hg.mozilla.org/mozilla-central/rev/e33f0c927b0b