189723 - [valgrind] Use of uninitialized value in nsCSSRendering::FillPolygon

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Debugging code in FillPolygon calls GetPenMode to check the pen mode. Only
Windows implements that function, and on other platforms FillPolygon ignores the
error return and tests the pen mode (which is garbage). Trivial patch follows.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 112000 [details] [diff] [review]
fix

trivial patch for you to review, bz

Comment 3

[Ruslan Ismailov]

Sorry, Robert, I think you should also remove previous line:

   aContext.GetPenMode(penMode);
-  if (penMode == nsPenMode_kInvert) {
+  if (NS_SUCCEEDED(aContext.GetPenMode(penMode)) && penMode == nsPenMode_kInvert) 

See, aContext.GetPenMode(penMode) calling two time.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

oh yeah! Thanks!

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 112002 [details] [diff] [review]
fix

better trivial patch :-)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 112002 [details] [diff] [review]
fix

Put the "&&" on the first line, please, not the second one.

Comment 8

[Andrew Schultz]

*** Bug 190645 has been marked as a duplicate of this bug. ***

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fix checked in.