1897330 - Trees in the library/organizer erroneously have margins and default appearance

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Shane Hughes [:aminomancer]]

Attachment: Screenshot of the issue

<tree> elements in the Library dialog have excessive margins and borders, due to removal of a CSS ruleset that previously overrode those base tree styles. See the attached screenshot.

Regression window:

 3:46.44 INFO: Last good revision: 662c76b01c88c73b3cf0839553cfd7768f435383
 3:46.44 INFO: First bad revision: 90f8db9f10ffcb58274d7fa750df6160e4fe38f0
 3:46.44 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=662c76b01c88c73b3cf0839553cfd7768f435383&tochange=90f8db9f10ffcb58274d7fa750df6160e4fe38f0

Specifically, it is due to this change.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1896330

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Gah, my fault, I found uses of it searching for this which misses the class="plain <somethingelse>" case.

Luckily it seems it's just those two <tree> elements.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1897330 - Reset places tree styles that were previously reset by the plain class. r=#theme,aminomancer

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9667f865ab00
Reset places tree styles that were previously reset by the plain class. r=aminomancer,desktop-theme-reviewers,places-reviewers,Itiel

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9667f865ab00

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is reproducible on a 2024-05-16 Nightly build on Windows 10.
Verified as fixed on Firefox 128.0b2 and Firefox Nightly 129.0a1 on Windows 10, Ubuntu 22, macOS 14.