Closed Bug 1897475 Opened 1 month ago Closed 1 month ago

disable tab previews in background windows

Categories

(Firefox :: Tabbed Browser, task, P1)

task

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: dwalker, Assigned: dwalker)

References

(Regressed 2 open bugs)

Details

Attachments

(2 files)

Tab previews that open from background windows are still causing window ordering issues on Linux, as well as unpredictable behavior upon restoration as seen in bug 1888148. I think we should only have tab previews activate on tabs in a foreground window for now to unblock release, and we can re-evaluate later.

Attachment #9402503 - Attachment description: WIP: Bug 1897475 - only fire TabHoverStart for topmost window. r?#tabbrowser-reviewers → Bug 1897475 - only fire TabHoverStart for topmost window. r?#tabbrowser-reviewers
Blocks: 1893676
Pushed by dwalker@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62e0691da306
only fire TabHoverStart for topmost window. r=tabbrowser-reviewers,niklas
Regressions: 1898099
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch

dwalker@: Background windows still showing Tab Hover Cards. Maybe a regression? Reproducible in Nightly 128.0a1 (2024-06-06) (64-Bit) and MacOS 14.5. Can you please take a look? Thanks.

Flags: needinfo?(dwalker)
Regressions: 1903042

Mehmet, does the preview show for all firefox windows in a stack? Or only for a firefox window that is backgrounded by another app? The fix here checks if the hovered tab is in the topmost window, but that doesn't seem to take into account other applications.

Either way the current fix has resolved a handful of issues, but there are others such as bug 1899556 that would be resolved by a better fix here.

Flags: needinfo?(dwalker) → needinfo?(mehmet.sahin)

Hi dwalker@. Thanks for your feedback. Yes, it happens when different Nightly windows are stacked as the most front application. That's okay - I see the same behavior also in Chrome. But it also happens, when other apps are in the foreground. Please find attached a screenshot, where the Finder is the most front application.

Flags: needinfo?(mehmet.sahin) → needinfo?(dwalker)
Flags: needinfo?(dwalker)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: