1897661 - Crash in [@ java.lang.NullPointerException: at org.mozilla.fenix.components.toolbar.BrowserToolbarView.<init>(BrowserToolbarView.kt:140)]

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect, P2)

Description

[Chris Peterson [:cpeterson]]

Crash report: https://crash-stats.mozilla.org/report/index/3435c147-fe6e-4541-acc5-4a9640240519

This crash is a regression in 128.0a1. The earliest crash report is from build ID 20240514215634.

java.lang.NullPointerException: getValue(...) must not be null

Top 10 frames:

0  org.mozilla.fenix.components.toolbar.BrowserToolbarView  <init>  BrowserToolbarView.kt:140
1  org.mozilla.fenix.browser.BaseBrowserFragment  initializeUI$app_fenixNightly  BaseBrowserFragment.kt:481
2  org.mozilla.fenix.browser.BrowserFragment  initializeUI$app_fenixNightly  BrowserFragment.kt:10
3  org.mozilla.fenix.browser.BaseBrowserFragment  onViewCreated  BaseBrowserFragment.kt:37
4  androidx.fragment.app.FragmentStateManager  createView  FragmentStateManager.java:284
5  androidx.fragment.app.FragmentStateManager  moveToExpectedState  FragmentStateManager.java:151
6  androidx.fragment.app.FragmentManager  executeOpsTogether  FragmentManager.java:1283
7  androidx.fragment.app.FragmentManager  removeRedundantOperationsAndExecute  FragmentManager.java:92
8  androidx.fragment.app.FragmentManager  execPendingActions  FragmentManager.java:77
9  androidx.fragment.app.FragmentManager$5  run  FragmentManager.java:4

Comment 1

[Chris Peterson [:cpeterson]]

This bug might be a regression from enabling the tab strip in bug 1894466. I checked the device models for some of the crash reports: they include some foldable phones, an x86 tablet, an Oculus headset, but also some devices that look like a regular, non-foldable phones.

Dropping the priority from P1 to P2 since the crash volume is pretty low and, assuming this is a regression from the tab strip, the crash won't ride to Beta or Release.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:rsainani, since you are the author of the regressor, bug 1896355, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Rahul Sainani [:rsainani]]

Attachment: Bug 1897661 - Fix tab strip NPE in BrowserToolbarView

Comment 4

[Rahul Sainani [:rsainani]]

Play Console crash data

I've created a patch for a potential fix. Surprisingly, the devices in the crash reports are prominently Samsung S 22/23/24 ultra, I wonder if the users have updated some developer settings to "simulate" the device as a tablet as those devices shouldn't be on the codepath where the crash has occured. Thinking out loud, if this was a more commonly occuring crash on a phone, UI tests and usage metrics would indicate that too.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bea56ddf574
Fix tab strip NPE in BrowserToolbarView r=android-reviewers,calu,007

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2bea56ddf574