1897737 - Screenshots filenames truncated when the OS Save dialog is triggered

Status: RESOLVED INVALID

(Firefox :: Screenshots, defect)

Description

[Simona Badau, Desktop QA]

Found in

• Firefox 127.0b3

Affected versions

• Firefox 127.0b3
• Nightly 128.0a1

Tested platforms

• Affected platforms: macOS 14. Ubuntu 22.04, Windows 10

Preconditions

• Ensure that the "Always ask you where to save files" option is enabled in about:preferences.

Steps to reproduce

1. Navigate to CNN.
2. Enable Screenshots using Ctrl+Shift+S.
3. Take a screenshot and select a location to save it.
4. Observe the filename of the saved screenshot.

Expected result

• The filename should follow the pattern: "Screenshot YYYY-MM-DD at hh-mm-ss website title".

Actual result

• The title of the website in the filename is truncated with an ellipsis. Example: Screenshot 2024-05-20 at 10-39-16 Five things you proba[...].png.

Regression range

• This issue seems to be a regression, as it does not occur in Firefox 126 with screenshots.browser.component.enabled set to true. I'll look for the regression range ASAP.

Comment 1

[Simona Badau, Desktop QA]

After looking for a regression window the behaviour I'm seeing might actually be by design. Please mark as Invalid if that's the case.

Found commit message:
Bug 1818862 - Revise how we generate a filename to fit inside platform pathname length constraints. r=niklas
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0beadc50afd86168f85dd997bc26a8fc9a9c2bdd&tochange=c77138bc1f869eb72bb8f573030c6e5bbdbb2ea8

Comment 2

[Haik Aftandilian [:haik]]

@Simona, I agree this appears to be working as design. The filenames are being shortened to be within OS limits. If there is a problem with the way the filename was shortened such as the filename was shortened unnecessarily or the [...] is causing a problem, then we should re-open the bug. Without the fix, did the filename get saved in full without [...]?