1897799 - New Tab Weather Widget: Unable to enable weather on new-tab; no error messages, no widget.

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[:glob ✱]

Firefox Nightly 128.0a1 (2024-05-20) on macOS 14.5.

Both browser.newtabpage.activity-stream.system.showWeather and browser.newtabpage.activity-stream.showWeather are set to true.

The widget doesn't appear at all on the New Tab page; the page looks identical in both configurations.
When browser.newtabpage.activity-stream.system.showWeather I see the option under Personalise to show weather, and it toggles browser.newtabpage.activity-stream.showWeather.

I don't see any error messages (or, more likely, I don't know where to look for them); checked browser console and stdout.

Comment 1

[:glob ✱]

Here's my debug log:

URLBar - MerinoClient [HNT_WEATHER_FEED]: Fetch starting with query: "" MerinoClient.sys.mjs:131:17
URLBar - MerinoClient [HNT_WEATHER_FEED]: SkippableTimer :: Merino session timeout :: Started UrlbarUtils.sys.mjs:2793:19
URLBar - MerinoClient [HNT_WEATHER_FEED]: Fetch details: {"query":"","providers":["accuweather"],"timeoutMs":5000,"url":"https://merino.services.mozilla.com/api/v1/suggest?q=&sid=32fd9d31-48f4-4529-8b74-1d8a0771aee6&seq=0&providers=accuweather"} MerinoClient.sys.mjs:196:17
URLBar - MerinoClient [HNT_WEATHER_FEED]: SkippableTimer :: Merino timeout :: Started UrlbarUtils.sys.mjs:2793:19
URLBar - MerinoClient [HNT_WEATHER_FEED]: Got response: {"response.status":200,"query":"","providers":["accuweather"],"timeoutMs":5000,"url":"https://merino.services.mozilla.com/api/v1/suggest?q=&sid=32fd9d31-48f4-4529-8b74-1d8a0771aee6&seq=0&providers=accuweather"} MerinoClient.sys.mjs:256:23
URLBar - MerinoClient [HNT_WEATHER_FEED]: SkippableTimer :: Merino timeout :: Canceling UrlbarUtils.sys.mjs:2793:19
URLBar - MerinoClient [HNT_WEATHER_FEED]: Response body: {"suggestions":[],"request_id":"1d41c47ebc284c03a3c17f99108ea51a","client_variants":[],"server_variants":[]} MerinoClient.sys.mjs:298:19
URLBar - MerinoClient [HNT_WEATHER_FEED]: Fetch done with status: no_suggestion MerinoClient.sys.mjs:199:19

I guess there's two issues here:

• empty suggestions from merino
• no feedback to the user that something went wrong

Comment 2

[Scott [:thecount] Downe]

There have been a few fixes in Merino since your last message that helped people get weather to show. Are you still seeing no weather widget?

Comment 3

[:glob ✱]

ty, I see the weather widget.

Is it worth focusing this bug on the lack of feedback when an unexpected response from Merino is received? (I can't confirm if this was also fixed by another bug).

Comment 4

[Scott [:thecount] Downe]

I think we can close this.

We also display slightly better error message if weather is enabled, but not getting any weather, instead of hiding it.

We also now show a loading state if we're just waiting on weather, but it's otherwise enabled and not in an error state.