1897968 - Typo in browserglue pref. checkbox not depended on pref.

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect)

Description

[Ina Popescu, Desktop QA]

Found in

• Firefox 127.0b4

Affected versions

• Firefox 127.0b4

Tested platforms

• Affected platforms: Windows10, macOS 11

Preconditions

• set pref browser.search.region = US in about:config
• install an older build than 127.0b4

Steps to reproduce

1. Go to Help > About Firefox and restart browser
2. Go to about:config and search pref extensions.formautofill.creditcards.reauth.optout

Expected result

• The pref extensions.formautofill.creditcards.reauth.optout doesn't hold any string because the "Require device sign in to fill and manage payment methods" checkbox is checked after updating the browser.

Actual result

• The pref extensions.formautofill.creditcards.reauth.optout holds encrypted string value after updating the browser.

Regression range

• N/A

Comment 1

[Sidharth Sachdev]

Attachment: Bug 1897968 - Typo in browserglue pref. checkbox not depended on pref. r=issammani

Comment 2

[Sidharth Sachdev]

Attachment: Bug 1897968 - Typo in browserglue pref. checkbox not depended on pref. r=issammani

Original Revision: https://phabricator.services.mozilla.com/D211043

Comment 3

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: OS Auth setting wont be preserved.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: None
• Explanation of risk level: A typo change
• String changes made/needed: None
• Is Android affected?: no

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d5d3b5bbb1b
Typo in browserglue pref. checkbox not depended on pref. r=issammani,firefox-desktop-core-reviewers DONTBUILD

Comment 5

[:Gijs (he/him)]

When I r+'d this I didn't realize this was in a migration.

Uplifting to beta will work for people who have not yet run this migration, but any existing beta users will have already set the pref with the "wrong" capitalization, and incremented the UI migration version, and so the migration will not re-run.

Comment 6

[Sidharth Sachdev]

Attachment: Bug 1897968 - Fix OS Auth pref migration. r=mconley!,issammani!

Comment 7

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/1d5d3b5bbb1b

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ssachdev, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Sidharth Sachdev]

We have a new bug that solves the problem for Beta. So no this patch in specific will not need an uplift but Bug1898323 will need an uplift once landed.

Comment 10

[Sidharth Sachdev]

Hey nevermind. We might need an uplift for this. We're still discussing. You'll have a decision by end of day.

Comment 11

[Sidharth Sachdev]

Attachment: Bug 1897968 - Typo in browserglue pref. checkbox not depended on pref. r=issammani

Original Revision: https://phabricator.services.mozilla.com/D211043

Comment 12

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Wrong pref setting will be made. New pref will be created which is not handled.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: NA
• Risk associated with taking this patch: minimal
• Explanation of risk level: minimal since we're only working with prefs.
• String changes made/needed: none.
• Is Android affected?: no

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/373dbaa6c4bb

Comment 14

[Ina Popescu, Desktop QA]

I've replicated this issue using Nightly 128.0a1 (2024-05-21) on macOS 11.
Verified as fixed in the latest Firefox 127.0 and Nightly 128.0a1 (2024-06-03) versions on Windows 10 x64 and macOS 11, as the issue no longer occurs.