1898323 - Fix OsAuth migration.

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Comment 1

[Sidharth Sachdev]

Attachment: Bug 1898323 - Fix OsAuth migration. r=gijs!,issammani!

Comment 2

[Sidharth Sachdev]

Attachment: Bug 1898323 - Fix OsAuth migration. r=gijs!,issammani!

Original Revision: https://phabricator.services.mozilla.com/D211245

Comment 3

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Incorrect migration will not be fixed.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: NA
• Risk associated with taking this patch: Minimal
• Explanation of risk level: only working with prefs. "browser.startup.homepage_override.mstone" is important but cleared after migration.
• String changes made/needed: None
• Is Android affected?: no

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72bfaae009ea
Fix OsAuth migration. r=issammani,firefox-desktop-core-reviewers ,Gijs

Comment 5

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/d71ad3109d39

Comment 6

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/e707bd0d7ab57b49775e6732a2f939e6908e655e
Backed out for causing xpcshell failures on beta

Comment 7

[Pascal Chevrel:pascalc]

Sidharth, can you look at the patch and make sure it works on beta?
If we can't have an updated patch for uplift for the 127 release, should we also back out Bug 1897968?
Thanks

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/72bfaae009ea

Comment 9

[:Gijs (he/him)]

Attachment: Bug 1898323 - Fix OsAuth migration for beta and have it disabled by default on Beta and Release. r=ssachdev!,issammani!

Comment 10

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Beta/release users get OS prompts for password/creditcard autofill
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Discussed out of band. Will need to test new profiles as well as upgrading from 126 beta to current beta and updating 126 -> 127b1 -> 127b9 and 126 -> 127b8 -> 127b9.
• Risk associated with taking this patch: Low-ish
• Explanation of risk level: Discussed via zoom and in https://docs.google.com/document/d/1HrTXUfZa-wSUSx9NDkg7JTQ1_OQoSdBZDqzt8edPHLI/edit - this is the lowest risk approach we can think of
• String changes made/needed: No
• Is Android affected?: no

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f02d0e14f2c2

Comment 12

[:Gijs (he/him)]

Attachment: Bug 1898323 - follow-up: fix tests now that beta/release default to not enabling CC/pwd autofill os reauth

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/a4678a17a6ff

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/3eb0dbd0e36b

Comment 15

[:Gijs (he/him)]

Attachment: Bug 1898323 - follow-up: fix more test + fix eslint by ignoring instead of changing the code, as that fails in plain mochitest

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/fedc004b1422

Comment 17

[:Gijs (he/him)]

Attachment: Bug 1898323 - fix about:logins and formautofill tests better given the disabling of OS reauth on beta/release

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/d4531cad6f4e

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 20

[Ina Popescu, Desktop QA]

Verified as fixed in the latest Firefox 127.0 and Nightly 128.0a1 on Windows10 x64 and macOS 11 based on the tests performed on these scenarios.