1898222 - Introduce a workaround for "storage.setCookie" command until CHIPS support is enabled

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Alexandra Borovova [:Sasha]]

At the moment, cookies, set with storage.setCookie command, are not available in document.cookie (which is expected by some Puppeteer tests). Basically this happens because we set partitionKey in originAttributes, this was recently fixed in the scope of this bug 1874174, but the changes are behind the feature flag network.cookie.cookieBehavior.optInPartitioning. This feature flag should be replaced soon, by a new one network.cookie.CHIPS.enabled (see the bug 1886133). The plan is to enable it in Nightly from 128, and start ride the train from 130 (see this comment.
The idea would be until the CHIPS support is enabled do not partition cookies (meaning to not set the partition key) which are set for the same domain as the page loaded in the targeted context (in case partition type “context”).
Doing a quick check with this test, I could see that a cookie set with the Set-Cookie header is present in document.cookie and this cookie partitionKey is equal to an empty string. So it looks like the proposal aligns with the current network requests behavior.

A work in progress patch is attached to illustrate the suggestion.

Pros:

• we don't have to wait for the preference to be enabled to start passing Puppeteer tests;
• seems to be aligning with the current network requests behavior.

Cons:

• diverges from the spec (?);
• requires the cleanup later.

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1898222 - [bidi] Introduce a workaround for "storage.setCookie" command until CHIPS support is enabled.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1898222 - [wpt] Use "storage.deleteCookies" in set_cookie fixture.

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1898222 - Update gecko specific test for "storage.setCookie" command.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4de5a0143e10
[bidi] Introduce a workaround for "storage.setCookie" command until CHIPS support is enabled. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/8560ec202e95
[wpt] Use "storage.deleteCookies" in set_cookie fixture. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/0aa517afc2a9
Update gecko specific test for "storage.setCookie" command. r=webdriver-reviewers,whimboo

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46565 for changes under testing/web-platform/tests

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4de5a0143e10
https://hg.mozilla.org/mozilla-central/rev/8560ec202e95
https://hg.mozilla.org/mozilla-central/rev/0aa517afc2a9

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged