1898346 - Feature callout theme transparency issue

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Shane Hughes [:aminomancer]]

Attachment: screenshot of the issue

Themes that use transparency for the wrong colors will result in a janky appearance (see attachment). We should use some color tricks to avoid there being any transparency on the callout box, at least until we find a better way to render arrows.

This problem arises with a recommended theme so it's especially problematic.

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: Bug 1898346 - Fix feature callout incompatibility with transparent theme variables. r=emcminn,negin,jprickett,hanna_a

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7b472920446
Fix feature callout incompatibility with transparent theme variables. r=negin,omc-reviewers

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f7b472920446

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Nightly 128.0a1 (Build ID: 20240606154042) installed on Windows 10 x64, macOS 14.1.1, and Ubuntu 22.04 x64. I can confirm the following:

• The callout background is solid.
• Only the callout's elements can be focused using "Shift+Tab".

Comment 5

[Shane Hughes [:aminomancer]]

Thanks Marius!