Closed Bug 1898574 Opened 4 months ago Closed 4 months ago

`check_maintenance` exception should do a None-check on `request.endpoint`

Categories

(Conduit :: Lando, defect, P3)

Product:
Conduit
Component:
Lando
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sheehan, Assigned: sheehan)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

[mozilla-conduit/lando-api] hooks: add a `None`-check before using `request.endpoint.startswith` (Bug 1898574) (#412)
53 bytes, text/x-github-pull-request
Details | Review

Flasks request.endpoint has a type of str | None, but the recent change from bug 1896696 always assumes the value is a str. This causes an error when random internet scanners try non-existent endpoints in LandoAPI. We should add a None-check to avoid this problem.

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: