1898588 - Support checking scheme per capability

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Alastor Wu [:alwu]]

Chromium and Webkit both support encryptionScheme already.

This feature is disabled by default and we're not fully implemented it as well. We should do that as well in order to implement checking scheme per capability.

Comment 1

[Alastor Wu [:alwu]]

Firefox is the only one failing on those wpt.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1898588 - part1 : add encryptionSchemes in MFCDMMediaCapability in order to support scheme per type

Currently our implementation is the scheme support per key system,
not per content type. As each content type can have different supported
scheme, we can't determine a precise result per content type.

eg. type A only supports cenc, but type B only supports cbcs.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1898588 - part2 : remove duplicated method 'EncryptionSchemeStr'.

Depends on D211642

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1898588 - part3 : add encryption scheme 'cbcs-1-9'.

Depends on D211643

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1898588 - part4 : check scheme per codec if encryptionScheme in MediaKeySystemMediaCapability exists.

Depends on D211644

Comment 6

[Alastor Wu [:alwu]]

I'm going to file another bug to flip the preference.

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1898588 - part5 : remove encryption scheme per key system.

Depends on D211645

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/940fca861f93
part1 : add encryptionSchemes in MFCDMMediaCapability in order to support scheme per type r=jolin
https://hg.mozilla.org/integration/autoland/rev/2643cfcd1ba7
part2 : remove duplicated method 'EncryptionSchemeStr'. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/62c4a3361e00
part3 : add encryption scheme 'cbcs-1-9'. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/dd7a777b034f
part4 : check scheme per codec if encryptionScheme in MediaKeySystemMediaCapability exists. r=jolin
https://hg.mozilla.org/integration/autoland/rev/d23ba62a5165
part5 : remove encryption scheme per key system. r=jolin

Comment 9

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on MediaData.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/9389ecc2777c26becf6f8f2d609b75bc0fa2bdf0
Log link: https://treeherder.mozilla.org/logviewer?job_id=460035160&repo=autoland&lineNumber=65641

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ed59369bf4a
part1 : add encryptionSchemes in MFCDMMediaCapability in order to support scheme per type r=jolin
https://hg.mozilla.org/integration/autoland/rev/e7a3702a2c8d
part2 : remove duplicated method 'EncryptionSchemeStr'. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/16a7d63e8efe
part3 : add encryption scheme 'cbcs-1-9'. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/71178e92209a
part4 : check scheme per codec if encryptionScheme in MediaKeySystemMediaCapability exists. r=jolin
https://hg.mozilla.org/integration/autoland/rev/4749767d42a9
part5 : remove encryption scheme per key system. r=jolin

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1ed59369bf4a
https://hg.mozilla.org/mozilla-central/rev/e7a3702a2c8d
https://hg.mozilla.org/mozilla-central/rev/16a7d63e8efe
https://hg.mozilla.org/mozilla-central/rev/71178e92209a
https://hg.mozilla.org/mozilla-central/rev/4749767d42a9