1898621 - WebRender should log why it failed to promote a surface

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Brad Werth [:bradwerth]]

As we rely on surface promotion to support wide color content, it is increasingly important that we can understand why a promotable surface was rejected for promotion. At minimum, we need this to go to gfxDebug, possibly gfxWarning. Eventually we should consider exposing this to web authors through the Developer Console or similar mechanism.

Comment 2

[Brad Werth [:bradwerth]]

Attachment: Bug 1898621: Provide error results for surface promotion methods.

This uses the warn macro for promotion errors. It's not clear this will
be useful for web authors, but hopefully it's useful for Firefox
developers.

Currently this spams warnings for unpromoted Image prims, which is not
great. It also doesn't have a great way of identifying which prim is
responsible for the error. I'll try to fix this up before marking this
as ready for review.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4b3fe2e03c6
Provide error results for surface promotion methods. r=gw

Comment 4

[Cristina Horotan [:chorotan]]

Backed out changeset d4b3fe2e03c6 (bug 1898621) for wrench failures

Backout: https://hg.mozilla.org/integration/autoland/rev/3c7dfdb94c52ad8804b1e40c67bb5cee5b3f5218

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d4b3fe2e03c6e43ebd89c91228f349ca95c8dc3d&selectedTaskRun=M8aTKZdfTwGSRelKOOD-Cw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=461237047&repo=autoland

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/032081e46073
Provide error results for surface promotion methods. r=gw,nical

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7f221a9e1db
Fix webrender bustages. r=bradwerth CLOSED TREE

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/032081e46073
https://hg.mozilla.org/mozilla-central/rev/c7f221a9e1db

Comment 8

[Timothy Nikkel (:tnikkel)]

I asked in #sheriffs for this to be backed out since merge day is monday.

Comment 9

[tszentpeteri]

Backed out as requested by tnikkel for causing bug 1901370

• Backout link

Comment 10

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/19b15cf93c3a

Comment 11

[Brad Werth [:bradwerth]]

Sorry for the trouble. I'll figure out the regression issues and re-land this after the merge date.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a06f8745fb4e
Provide error results for surface promotion methods. r=gw,nical

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a06f8745fb4e