Closed Bug 1898649 Opened 8 months ago Closed 8 months ago

Disable cert_verifier.cert_trust_evaluation_time metric on Android

Categories

(Core :: Security: PSM, task)

task

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox126 --- fixed
firefox127 --- fixed
firefox128 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This metric is recorded 600 times during a browser restore of cnn.com and looks to be the most frequently recorded metric in the parent after performance.clone.deserialize from bug 1898515.

Blocks: 1892230

This metric is recorded 600 times during a browser restore of cnn.com
and looks to be the most frequently recorded metric in the parent after
performance.clone.deserialize from bug 1898515.

Assignee: nobody → jmuizelaar
Status: NEW → ASSIGNED

Comment on attachment 9403748 [details]
Bug 1898649. Disable cert_verifier.cert_trust_evaluation_time metric on Android.

Beta/Release Uplift Approval Request

  • User impact if declined: We spend a lot of extra cpu time and do a lot of extra disk writes during page load.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This just disables recording the cert_verifier.cert_trust_evaluation_time metric on Android it should otherwise have no functional change.
  • String changes made/needed:
  • Is Android affected?: Yes
Attachment #9403748 - Flags: approval-mozilla-release?
Attachment #9403748 - Flags: approval-mozilla-beta?
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4a540b2d531 Disable cert_verifier.cert_trust_evaluation_time metric on Android.

I got a verbal go-ahead from jschanck over slack before landing this.

Blocks: 1898810
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch

Comment on attachment 9403748 [details]
Bug 1898649. Disable cert_verifier.cert_trust_evaluation_time metric on Android.

Approved for 127.0b7

Attachment #9403748 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9403748 [details]
Bug 1898649. Disable cert_verifier.cert_trust_evaluation_time metric on Android.

Approved for 126.0.1

Attachment #9403748 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: