1898817 - Migrate various `distutils` usages in first-party python modules

Status: RESOLVED FIXED

(Firefox Build System :: General, task, P3)

Description

[Alex Hochheiden [:ahochheiden]]

Not really sure what product to file this under, since there's several usages in several different modules, and I'd rather not raise a new bug for each one.

Comment 1

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1898817 - Replace `distutils.spawn.find_executable` with `shutil.which` within `mozlint` r?ahal

Comment 2

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1898817 - Replace `distutils.spawn.find_executable` with `shutil.which` within `mozperftest` r?#mozperftest-reviewers

Comment 3

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1898817 - Add custom `copy_tree_update` to replace `distutils.dir_util.copy_tree` r?#mozperftest-reviewers

We can't use shutil.copy_tree here, since we need the update=True
functionality implemented by the distutils variant, but not by the
shutil one. This looks like the only place in the repo we use this
functionality, so it seems fine to implement an equivalent ourselves
here directly.

Comment 4

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1898817 - Replace `distutils.sysconfig` with `sysconfig.get_paths` to get the site pacakages directory in `mozharness` r?ahal

Comment 5

[Alex Hochheiden [:ahochheiden]]

Attachment: Bug 1898817 - Replace `distutils.util.strtobool` with `mach.util.strtobool` in `raptor` r?#perftest-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb50a220de69
Replace `distutils.spawn.find_executable` with `shutil.which` within `mozlint` r=ahal
https://hg.mozilla.org/integration/autoland/rev/c68493490b5c
Replace `distutils.spawn.find_executable` with `shutil.which` within `mozperftest` r=mozperftest-reviewers,sparky
https://hg.mozilla.org/integration/autoland/rev/2fc073aab920
Add custom `copy_tree_update` to replace `distutils.dir_util.copy_tree` r=mozperftest-reviewers,sparky
https://hg.mozilla.org/integration/autoland/rev/91cfbbe6cacd
Replace `distutils.sysconfig` with `sysconfig.get_paths` to get the site pacakages directory in `mozharness` r=ahal
https://hg.mozilla.org/integration/autoland/rev/4b2b91958615
Replace `distutils.util.strtobool` with `mach.util.strtobool` in `raptor` r=perftest-reviewers,afinder

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out 8 changesets (Bug 1899681, Bug 1888570, Bug 1898817) as requested by the dev CLOSED TREE

Failure Log: https://treeherder.mozilla.org/logviewer?job_id=462065796&repo=autoland&lineNumber=890

Backout: https://hg.mozilla.org/integration/autoland/rev/48183268590c481e37309299d130508c7d1dc43e

Comment 8

[Alex Hochheiden [:ahochheiden]]

Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1fb12118815
Replace `distutils.spawn.find_executable` with `shutil.which` within `mozlint` r=ahal
https://hg.mozilla.org/integration/autoland/rev/9e98a131b967
Replace `distutils.spawn.find_executable` with `shutil.which` within `mozperftest` r=mozperftest-reviewers,sparky
https://hg.mozilla.org/integration/autoland/rev/75d8387e1265
Add custom `copy_tree_update` to replace `distutils.dir_util.copy_tree` r=mozperftest-reviewers,sparky
https://hg.mozilla.org/integration/autoland/rev/39c3934ec741
Replace `distutils.sysconfig` with `sysconfig.get_paths` to get the site pacakages directory in `mozharness` r=ahal
https://hg.mozilla.org/integration/autoland/rev/f74c3b8ceafd
Replace `distutils.util.strtobool` with `mach.util.strtobool` in `raptor` r=perftest-reviewers,afinder

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a1fb12118815
https://hg.mozilla.org/mozilla-central/rev/9e98a131b967
https://hg.mozilla.org/mozilla-central/rev/75d8387e1265
https://hg.mozilla.org/mozilla-central/rev/39c3934ec741
https://hg.mozilla.org/mozilla-central/rev/f74c3b8ceafd