1898818 - Home and newtab wallpapers need to work with both light and dark mode and still look good

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Scott [:thecount] Downe]

Essentially if you set a wallpaper that looks good in light mode, but set your theme to dark, we need to do some fixing to a few elements.

These elements are:

1. Logo wordmark above search.
2. The personalize icon.
3. Some of the text on the page, but not all of it.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1898818 - Home and newtab fixes so newtab with a wallpaper looks good in both light and dark mode

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/336b84060ad6
Home and newtab fixes so newtab with a wallpaper looks good in both light and dark mode r=desktop-theme-reviewers,home-newtab-reviewers,omc-reviewers,sfoster,aminomancer,amy

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/336b84060ad6

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement using the steps from here and I can confirm the following:

• The Firefox logo is correctly displayed above the in-content "Search Bar".
• The "Personalize" button is correctly displayed and visible if it is not displayed on the "Search Bar".
• All the text from the "New Tab" page is visible.

That being said during the verification we observed that the "Personalize" icon is barely visible when displayed on the "Search Bar and an opposite color wallpaper to the theme is set. However, we logged a separate issue for this: bug 1901243.

Verified using the latest Firefox Nightly 128.0a1 (Build ID: 20240606154042) installed on Windows 10 x64, macOS 14.1.1, and Ubuntu 22.04 x64.