1900043 - New tab page text is dark making it hardly readable

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: ntp text color.png

Found in

• Firefox 128.0a1 (2024-05-31)

Affected versions

• Firefox 128.0a1 (2024-05-31)

Tested platforms

• Affected platforms: Windows 10/11, macOS 14.5, Ubuntu 24.04

Preconditions

• Dark OS theme is set and System default theme is set on Firefox (doesn't reproduce on Light/Dark)

Steps to reproduce

1. Launch Firefox access a new tab page

Expected result

• Text color is rendered in white

Actual result

• Text color is rendered dark

Regression range

• Bug 1898818 - Home and newtab fixes so newtab with a wallpaper looks good in both light and dark mode

Additional notes

• The issue can be seen in the attachment

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1898818

:thecount, since you are the author of the regressor, bug 1898818, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Scott [:thecount] Downe]

Thanks for catching, I can reproduce. I think I know what's going on.

Comment 3

[Scott [:thecount] Downe]

Attachment: Bug 1900043 - Home and newtab fixing regression for light and dark mode caused by wallpaper contextual text colour changes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eec250fb98ed
Home and newtab fixing regression for light and dark mode caused by wallpaper contextual text colour changes. r=home-newtab-reviewers,maxx

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/eec250fb98ed

Comment 6

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified that the issue is fixed on Firefox 128.0b1 and Firefox 129.0a1. Tests were performed on macOS 14.5, Windows 11 and Ubuntu 24.04.