1899030 - Separate ASRouter JS dependencies from newtab content code

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Shane Hughes [:aminomancer]]

There are many ways ASRouter is still tangled up with the newtab content code, which results in the newtab team needing to rebuild ASRouterAdmin when they make changes to newtab code, and results in us getting pinged for review on their patches. There are too many ways to tackle in one bug, so I've separated this into several bugs (see See Also section above). But this bug will be for all the low-hanging fruit, things that can be changed without sweeping changes, without affecting too many tests, etc.

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: Bug 1899030 - Part 1: Remove ASRouterUserEvent from Actions.mjs. r=#omc-reviewers,#home-newtab-reviewers,mconley

Also remove unused action types and the unused ASRouter reducer.

Comment 2

[Shane Hughes [:aminomancer]]

Attachment: Bug 1899030 - Part 2: Move remote-text component to asrouter. r=#omc-reviewers,#home-newtab-reviewers,mconley

Comment 3

[Shane Hughes [:aminomancer]]

Attachment: Bug 1899030 - Part 3: Define the onboarding provider pref outside of newtab. r=#omc-reviewers,#home-newtab-reviewers,mconley

Comment 4

[Shane Hughes [:aminomancer]]

Attachment: Bug 1899030 - Part 4: Remove unused ASRouterButton import in newtab. r=#omc-reviewers,#home-newtab-reviewers,mconley

Comment 5

[Shane Hughes [:aminomancer]]

Attachment: Bug 1899030 - Part 5: Remove miscellaneous unused asrouter code from newtab. r=#omc-reviewers,#home-newtab-reviewers,mconley

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df4071e257d9
Part 1: Remove ASRouterUserEvent from Actions.mjs. r=mconley,omc-reviewers,home-newtab-reviewers,negin,firefox-desktop-core-reviewers ,pdahiya,thecount
https://hg.mozilla.org/integration/autoland/rev/8176aad1b73b
Part 2: Move remote-text component to asrouter. r=mconley,omc-reviewers,home-newtab-reviewers,negin,pdahiya,thecount
https://hg.mozilla.org/integration/autoland/rev/16da2805877d
Part 3: Define the onboarding provider pref outside of newtab. r=mconley,omc-reviewers,home-newtab-reviewers,negin,pdahiya,thecount
https://hg.mozilla.org/integration/autoland/rev/362de53134c5
Part 4: Remove unused ASRouterButton import in newtab. r=omc-reviewers,home-newtab-reviewers,nbarrett,pdahiya
https://hg.mozilla.org/integration/autoland/rev/da69a62e5ac9
Part 5: Remove miscellaneous unused asrouter code from newtab. r=mconley,omc-reviewers,frontend-codestyle-reviewers,pdahiya

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/df4071e257d9
https://hg.mozilla.org/mozilla-central/rev/8176aad1b73b
https://hg.mozilla.org/mozilla-central/rev/16da2805877d
https://hg.mozilla.org/mozilla-central/rev/362de53134c5
https://hg.mozilla.org/mozilla-central/rev/da69a62e5ac9