189951 - [imap] preserve "junkscoreorigin" attribute

Status: NEW

(MailNews Core :: Backend, defect)

Description

[(not reading, please use [e-mail] instead)]

in nsImapMailFolder::HandleCustomFlags() we are assuming that the origin of the
junk status is from the plugin.  we assume the message was moved to the folder
by the plugin, so when we open the dest folder and see the message, we set the
junkscoreorigin attribute to be "plugin".

here's a scenario where our assumption is wrong:
the user manually set the status (to be junk or not junk) and then moves the
message.  when we open the dest folder, we'll restore the junkscore properly,
but set the junkscoreorigin to plugin, when it should be user.

notes:

[1] the junkscoreorigin attribute is used to determine what the plugin does if
we reclassify.  (if from user, on re-classify we have to update both tables, on
plugin, just one.)

[2] I claim our assumption is ok (for now) because if the user manually sets the
 classification, they are less likely to re-classify again.  and if they don't
reclassify, it doesn't matter if the origin is wrong.

, I claim our assumption is this is

Comment 1

[(not reading, please use [e-mail] instead)]

", I claim our assumption is this is", ignore that cruft.

david is going to #if 0 out the code that sets the junkscoreorigin, since if we
don't set it, the code in nsMsgDBView::SetJunkScoreByIndex() will treat it the
same as if it was "plugin".

but the bug is still valid, since we should figure out how to preserve this.

but I doubt we'll do that any time soon.

Comment 2

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 3

[Serge Gautherie (:sgautherie)]

Filter on "Nobody_NScomTLD_20080620"

Comment 4

[Wayne Mery (:wsmwk)]

rkent, did you intend to assign this to yourself on 2008-08-07 ?

Comment 5

[Kent James (:rkent)]

I'm not sure what I had in mind, actually. I've done a lot of work with junkscoreorigin, but I am not convinced that preserving it is critical. Occasionally miscategorizing a previous training is not a very serious error.