180857 - make spam-status more strongly bound to the message on IMAP

Status: VERIFIED FIXED

(MailNews Core :: Filters, enhancement)

Description

[Dan Mosedale (:dmosedale, :dmose)]

We want spam-status to be persist across message moves, and (in the case of
IMAP) viewable from multiple clients.  For IMAP, we'll probably confine this to
servers that support keywords.  bienvenu, how would you recommend doing this for
local/POP (eg for when messages are moved between folders)?

Comment 1

[David :Bienvenu]

for copying messages between local folders, I would have thought this would just
work. I'll look into it.

Comment 2

[David :Bienvenu]

it already works for move/copying messages between local folders. For copying
from imap to local folders, if we care, we'll need to figure out something.

Comment 3

[Jon Granrose]

this would be nice for imap.  it's annoying seeing the "junk status unknown"
icon when I move a message to a folder then view that folder, or delete a
message and decide I want it back and do undo.  In either case they have the
"unknown" icon.

Alternatively, you could analyze any "junk status unknown" emails every time you
enter a folder whether they're old or new, although that sounds wasteful.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

*** Bug 181040 has been marked as a duplicate of this bug. ***

Comment 5

[laurel]

*** Bug 182421 has been marked as a duplicate of this bug. ***

Comment 6

[laurel]

nominating for next release - IMAP

Comment 7

[David :Bienvenu]

Attachment: use imap keywords to store junk/non-junk status

this patch uses imap custom keywords to store junk/non junk status. This means
that imap messages that are scored and then moved to other imap folders will
have their status carried along with them, and we won't rescore them (if
they're unread/new), or show their status as unknown. This does not affect
local messages.

Comment 8

[David :Bienvenu]

taking.

Comment 9

[Nicolás Lichtmaier]

I guess the same applies if I connect from diferent Mozilla's to the same
account, right?

Comment 10

[David :Bienvenu]

yes, it applies when mozilla is run from different machines against the same
imap folders as well.

Comment 11

[(not reading, please use [e-mail] instead)]

david is going to make a few changes related to the junkscoreorigin attribute,
and then checkin, r/sr=sspitzer

there's a spin off issue, I'll log in and link to it.

Comment 12

[David :Bienvenu]

fix checked in - bear in mind, this is only for imap, which is what this bug is
about.

Comment 13

[(not reading, please use [e-mail] instead)]

spin off issue (about junkscoreorigin attribute) is bug #189951

from that bug:

"I claim our assumption is ok (for now) because if the user manually sets the
 classification, they are less likely to re-classify again.  and if they don't
reclassify, it doesn't matter if the origin is wrong."

david, do we need another spin off bug about not doing this on ever folder open
(or something like that?)

Comment 14

[(not reading, please use [e-mail] instead)]

"david, do we need another spin off bug about not doing this on ever folder open
(or something like that?)"

ignore me.  I was confused.

Comment 15

[esther]

Seth and David, I read this bug and seth's spin off bug but am still not sure I
understand what is suppose to happen when the user changes their mind about an
IMAP message in their Inbox that is flagged as Junk.  I ran into this and am
seeing that messages flagged as Junk in the Inbox are not changing the status on
the server when I remove the junk status in the thread pane of the Inbox. 

1. Launch Mail and log into your IMAP account.
2. Mark several messsages as Junk, don't move them for this test.  Ping the
server by getting new messages or waiting for biff.
3. Exit the app 
4. Relaunch app and open your IMAP account again.
5. Remove the junk status of a couple of your messages that are marked as Junk.
 Ping the server again so this change can take place on the server.
6. Exit the app and relaunch again, logging into that same account.

Result: the messages in my Inbox that I removed the junk status from are
reflagged as junk. 
Expected: the messages in my Inbox that I removed the junk status from should
not have the junk status.

Note, I tried this with by creating a new profile in step 6 so there wasn't an
issue with the training.dat file, that new profile brought the messages in as
junk, this means they are still flagged as junk on the server.  

Comment 16

[David :Bienvenu]

Attachment: proposed fix

we weren't subtracting the flags correctly.

Comment 17

[David :Bienvenu]

I'd like to see this fix checked into 1.3b

Comment 18

[(not reading, please use [e-mail] instead)]

Comment on attachment 112829 [details] [diff] [review]
proposed fix

thanks david.

r/sr=sspitzer

I'll seek approval.

Comment 19

[Asa Dotzler [:asa]]

Comment on attachment 112829 [details] [diff] [review]
proposed fix

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 20

[(not reading, please use [e-mail] instead)]

I've checked in david's supplimental patch.

thanks, david.

Comment 21

[esther]

Thanks, I'll test it asap.  

Comment 22

[esther]

Using trunk build 20030128 on winxp, linux and mac osx I verfified the portion
of this bug where changing the junk status of a message in the IMAP Inbox is
holding.  Now I need to verify that the junk status moves to another folder. 

Comment 23

[esther]

Using trunk build 20030128 on linux, mac osx and winxp email messages flagged as
Junk in an IMAP folder stay flagged as Junk when moving the message to another
IMAP folder.  Verifying this bug as stated, I will open a new one for the IMAP
to POP move/copy not keeping the junk status.  Also, found a side bug regarding
changing the status, then pinging the server causes status of that message to
lose the Junk icon in thread view, the server appears to keep the status state.
I will log a separate bug for these two issues.

Comment 24

[esther]

*** Bug 190908 has been marked as a duplicate of this bug. ***

Comment 25

[esther]

*** Bug 190356 has been marked as a duplicate of this bug. ***

Comment 26

[esther]

on the 1-28 5 am build, I see this:

mark a message as junk (using the thread pane icon)
hit get msg
message becomes not junk.

wasn't david's fix (checked in on 1-27 by seth) supposed to fix that?

Comment 27

[David :Bienvenu]

yes, that should have fixed it. My local debug build works fine, but the release
build I downloaded doesn't - I'll have to go look at the checkin, and my patch.

Comment 28

[David :Bienvenu]

hmm, I tried it again with my release build and it worked this time. So there's
something weird going on.

Comment 29

[esther]

After I exited the app and relaunched the junk status was there.  I haven't seen
this again today with the same build.  What I reporteded in comment 15 was the
server not removing the junk flag per my removal in the UI.  In this more recent
case I was adding the Junk status via UI, the UI was removing it within a minute
but the server it kept the junk flag.  I will investigate more and log a new bug
if I can reproduce. 

Comment 30

[esther]

*** Bug 191289 has been marked as a duplicate of this bug. ***