1899601 - Fix 1-click set-to-default

Status: RESOLVED FIXED

(Firefox :: Shell Integration, enhancement, P2)

Comment 1

[Nick Rishel [:nrishel]]

Attachment: Bug 1899601 - Part 1: Fix 1-click set-to-default for NSIS and MSI installs. r=nalexander

Comment 2

[Nick Rishel [:nrishel]]

Attachment: Bug 1899601 - Part 2: Fix 1-click set-to-default for MSIX installs. r=nalexander

Comment 3

[Nick Rishel [:nrishel]]

Attachment: Bug 1899601 - Part 3: Lock 1-click set-to-default fix behind Nimbus configurable pref. r=nalexander

Nimbus Feature: shellService.setDefaultBrowserUserChoiceRegRename
about:config pref: browser.shell.setDefaultBrowserUserChoice.regRename

Comment 4

[Nick Alexander :nalexander [he/him]]

Barret -- could you peek at the 3rd patch and suggest if we should add isStartup: true? I think yes -- it's possible this is invoked very early, possibly before Nimbus is ready -- but perhaps not, I know there have been many changes around experiment prefs.

Comment 5

[Beth Rennie [:beth] (she/her)]

Do you mean specifically the setDefaultBrowserUserChoiceRegRename variable / browser.shell.setDefaultBrowserUserChoice.regRename pref? If so, no you dont need to use isEarlyStartup to make it available, as long as you always read from the pref (instead of the variable) during early startup.

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to Barret Rennie [:barret] (they/them) from comment #5)

Do you mean specifically the setDefaultBrowserUserChoiceRegRename variable / browser.shell.setDefaultBrowserUserChoice.regRename pref? If so, no you dont need to use isEarlyStartup to make it available, as long as you always read from the pref (instead of the variable) during early startup.

That is exactly what I meant, and yes -- consumers read the preference, AFAICT. Thanks for confirming, Barret!

Comment 7

[Nick Rishel [:nrishel]]

Originally this is marked confidential so the relevant code would not be exposed if we chose not to land it. As we have chosen to proceed with landing and the code will be public, this no longer needs to be confidential.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23c296923575
Part 1: Fix 1-click set-to-default for NSIS and MSI installs. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/f1d1b1ae8abe
Part 2: Fix 1-click set-to-default for MSIX installs. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/a78c2ee248a6
Part 3: Lock 1-click set-to-default fix behind Nimbus configurable pref. r=nalexander

Comment 9

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/23c296923575
https://hg.mozilla.org/mozilla-central/rev/f1d1b1ae8abe
https://hg.mozilla.org/mozilla-central/rev/a78c2ee248a6