Closed Bug 1915722 Opened 2 months ago Closed 1 month ago

Support holdback for one-click Set to Default users default experience

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Iteration:
133.1 - Sep 30 - Oct 11

People

(Reporter: pdahiya, Assigned: mviar)

References

(Blocks 1 open bug)

Details

(Whiteboard: [omc])

Scope of this bug is to implement one-click set to default wins rolled out via Nimbus , default experience in Firefox Desktop

To track cumulative impact of H2 2024 experiments, we need to ensure holdback branch of long-term-holdback-2024-h2-velocity-desktop not see one-click-set to default experience as discussed here

https://experimenter.services.mozilla.com/nimbus/long-term-holdback-2024-h2-velocity-desktop/summary

See Also: → 1913811
Whiteboard: [omc]
Summary: Make one-click Set to Default for new users default experience → Make one-click Set to Default users default experience

Hi Venetia - what are your thoughts about doing this before the end of the H2 holdback? We could potentially uplift this into Fx131 Beta.

Flags: needinfo?(vtay)

YES - if we can, we should.

Nicholas was also planning to implement it on the background updater as well

Flags: needinfo?(vtay)
Depends on: 1899601

Thanks @vtay. NI @nrishel to help link the implementing bug . I believe fix will be flipping prefs that powers feature variables "setDefaultGuidanceNotifications", "setDefaultBrowserUserChoiceRegRename".

As per timeline and scope of the fix, we can repurpose this bug to support holdback study by launching a shellService feature rollout with no-one-click that enrolls only users from holdback branch of LTH.

Flags: needinfo?(nrishel)
See Also: → 1916780

Sounds like a plan, and yes changing the pref is sufficient for setDefaultBrowserUserChoiceRegRename and setDefaultGuidanceNotifications (the latter is already pref-ed on by default). I'll work on a patch in Bug 1916780.

Should we uplift to beta once landed?

Flags: needinfo?(nrishel)

(In reply to Nick Rishel [:nrishel] from comment #4)

Sounds like a plan, and yes changing the pref is sufficient for setDefaultBrowserUserChoiceRegRename and setDefaultGuidanceNotifications (the latter is already pref-ed on by default). I'll work on a patch in Bug 1916780.

Should we uplift to beta once landed?

Yes beta uplift request once Bug 1916780 fix lands in Nightly and QA verified. setDefaultGuidanceNotifications pref-end on by default, my understanding we don't want to show guidance notification once setDefaultBrowserUserChoiceRegRename (one-click) is turned on , unless back-end functionality handles showing guidance notification only for users on devices where one-click set default fails.

Guidance notification is only show when 1-click fails, so we can leave it on.

Summary: Make one-click Set to Default users default experience → Support holdback for one-click Set to Default users default experience
Iteration: --- → 132.1 - Sep 2 - Sep 13
Priority: -- → P1

We'll want to put an experiment recipe together for QA testing in beta.

Assignee: nobody → mviar
Duplicate of this bug: 1916775
No longer duplicate of this bug: 1916775
Iteration: 132.1 - Sep 2 - Sep 13 → 132.2 - Sep 16 - Sep 27

Here's the initial recipe created by @pdahiya to ensure no one click set to default rollout for users in the long-term holdback branch.

Iteration: 132.2 - Sep 16 - Sep 27 → 133.1 - Sep 30 - Oct 11

This was launched on September 30th.

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.