189974 - Profile Switching fails after JavaScript based cert import

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P1)

Description

[Kai Engert [:KaiE:]]

Use the special test build containing the patch from bug 97622.
Use the intranet page at
  https://pki.mcom.com:1025/ca/DirUserEnroll1024.html
to obtain a test certificate.
Switch the profile.

Actual behaviour: profile switching fails.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Partial fix

I believe bug 189976 needs to be fixed, however, it seems there is another leak
in PSM. I believe this patch will be required in addition to make it work.

Comment 2

[Kai Engert [:KaiE:]]

Comment on attachment 112183 [details] [diff] [review]
Partial fix

Javi, can you please review?
caPubs is created using CMMF_CertRepContentGetCAPubs, which calls
cmmf_MakeCertList, defined here:
http://lxr.mozilla.org/seamonkey/source/security/nss/lib/crmf/respcmn.c#154

Comment 3

[Javier Delgadillo]

Comment on attachment 112183 [details] [diff] [review]
Partial fix

r=javi

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 112183 [details] [diff] [review]
Partial fix

Darin, can you please review this one-liner?

Comment 5

[Darin Fisher]

Comment on attachment 112183 [details] [diff] [review]
Partial fix

rs=darin

Comment 6

[Kai Engert [:KaiE:]]

It seems we have fixes for this issue. When using both the patches from this bug
and bug 189976, the issue is fixed for me.

Comment 7

[Kai Engert [:KaiE:]]

Comment on attachment 112183 [details] [diff] [review]
Partial fix

I'm nominating this patch (plus the patch in bug 189976) for inclusion in 1.3
beta. It would allow us to do better testing of the new profile switching
feature.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 112183 [details] [diff] [review]
Partial fix

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 9

[Kai Engert [:KaiE:]]

Checked in to trunk, marking fixed.
Fix will be contained in 1.3 beta.

Comment 10

[John Unruh]

Verified fixed.