1899949 - Implement parsing of CSS 'position-try-options' property

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1899949. Implement parsing of CSS 'position-try-options' property. r=emilio

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Bug 1899949 p2. Enable layout.css.anchor-positioning.enabled for css/css-anchor-position/parsing/position-try-options-parsing.html. r=emilio

Depends on D212335

Comment 3

[Jonathan Watt [:jwatt]]

Emilio, is there somehow a way to preserve the order of flags when #[css(bitflags is used to store them? I'm using bitflags for PositionTryOptionsTryTactic, but when test_valid_value is called in position-try-options-parsing.html, an argument for serializedValue is not passed, which means that the canonical order of the keywords is expected to be the order in which they were specified.

This must mean that Chrome supports preserving keyword ordering, and I'm guessing we've encountered this issue before.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

No, the right thing to do is serializing in the canonical ordering. Canonical ordering is the order in which they appear in the CSS spec. If chrome is serializing using specified order instead of canonical, it's a bug in chrome.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1899949 - Add the ability to have a custom parse function to derived variants. r=#style,#layout

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd33c3d00f8b
Add the ability to have a custom parse function to derived variants. r=jwatt

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/fd33c3d00f8b

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adf81b513db5
Implement parsing of CSS 'position-try-options' property. r=emilio,firefox-style-system-reviewers
https://hg.mozilla.org/integration/autoland/rev/8631cededbb3
p2. Enable layout.css.anchor-positioning.enabled for css/css-anchor-position/parsing/position-try-options-parsing.html. r=emilio

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/adf81b513db5
https://hg.mozilla.org/mozilla-central/rev/8631cededbb3