1900022 - Various quad shader cleanups

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1900022 - Rename APPLY_DEVICE_CLIP into APPLY_RENDER_TASK_CLIP. r=gw

I think that it's more informative to explain what the clip represents than its coordinate space in the name of the flag. The documentation for the flag is extended to explain the coordinate space and its relation with the render task rect.

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1900022 - Rename push_quad into prepare_quad. r=gw

It gives a bit more context about where the function fits in the overall pipeline (the prepare phase).

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1900022 - Explain what coordinate space is involved for each quad rendering strategy. r=gw

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 1900022 - Rename SAMPLE_AS_MASK into IS_MASK and move to the base quad shader. r=gw

The feature could be used by other shaders, for example gradient masks currently fall back to blob images but we should use shaders for them instead.

Comment 5

[Nicolas Silva [:nical]]

Attachment: Bug 1900022 - Rename init_transfom_vs/fs into rectangle_aa_vertex/fragment. r=gw

The new names better match what the functions are about. There used to be a 1-1 relation betwee transforms and antialiasing, but that's not true anymore with SVG rects.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f85989337c8c
Rename APPLY_DEVICE_CLIP into APPLY_RENDER_TASK_CLIP. r=gw
https://hg.mozilla.org/integration/autoland/rev/073e06f01543
Rename push_quad into prepare_quad. r=gw
https://hg.mozilla.org/integration/autoland/rev/1ce108503e31
Explain what coordinate space is involved for each quad rendering strategy. r=gw
https://hg.mozilla.org/integration/autoland/rev/aa4913edc4ea
Rename SAMPLE_AS_MASK into IS_MASK and move to the base quad shader. r=gw
https://hg.mozilla.org/integration/autoland/rev/b60f14d8d3d8
Rename init_transfom_vs/fs into rectangle_aa_vertex/fragment. r=gw

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f85989337c8c
https://hg.mozilla.org/mozilla-central/rev/073e06f01543
https://hg.mozilla.org/mozilla-central/rev/1ce108503e31
https://hg.mozilla.org/mozilla-central/rev/aa4913edc4ea
https://hg.mozilla.org/mozilla-central/rev/b60f14d8d3d8