1900312 - FOG: Warning generated on Rust code when keys use CamelCasing

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P2)

Description

[Jan-Erik Rediger [:janerik] (Away until 2025-06-23)]

[task 2024-05-30T16:11:45.075Z] 16:11:45     INFO -  45781 |           pub brokenAddBlockers: AsyncShutdownTimeoutObjectItemBrokenaddblockers,
[task 2024-05-30T16:11:45.075Z] 16:11:45     INFO -        |               ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `broken_add_blockers`
[task 2024-05-30T16:11:45.076Z] 16:11:45     INFO -        |

should be broken_add_bockers

Comment 1

[Jan-Erik Rediger [:janerik] (Away until 2025-06-23)]

Ah! I realized that the original code had the brokenAddBlockers casing in the metrics.yaml. We don't change casing for names in the structure.
But we can add the annotation that makes the warning go away.

Comment 2

[Jan-Erik Rediger [:janerik] (Away until 2025-06-23)]

Attachment: Bug 1900312 - Add allow-lint annotation to generated code r?TravisLong

This means CamelCasing (or any other casing) for structure fields is now possible
without Glean transforming those names in any way.
Note that the generated Rust code will have the same CamelCase naming,
which might be unusual.
JavaScript will also need to pass in the object fields exactly as
written in the corresponding metrics.yaml definition.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e706d009236
Add allow-lint annotation to generated code r=TravisLong

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2e706d009236