1830098 - Implement the subset of Telemetry Environment metrics useful for crash pings as Glean metrics

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, task)

Description

[Alex Franchuk [:afranchuk]]

This follows on from the analysis done in bug 1819425. The document discussing the metrics is here.

Comment 1

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1830098 - Implement Telemetry Environment metrics as Glean metrics r=gsvelto

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:afranchuk, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Alex Franchuk [:afranchuk]]

Was away the last 2 weeks. Will get back to landing this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/124c0a72502a
Implement Telemetry Environment metrics as Glean metrics r=gsvelto

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out with Bug 1815316 for causing bustage on metrics.rs related to brokenAddBlockers

• backout: https://hg.mozilla.org/integration/autoland/rev/5a1dc23c99121876b02c131fd208dd3fc5c1ab4b
• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=2f9704b70a8adeab72614f07d1e63ca4cff953a9
• failure log: https://treeherder.mozilla.org/logviewer?job_id=460347666&repo=autoland&lineNumber=49430

[task 2024-05-30T16:11:45.074Z] 16:11:45     INFO -       Running `CARGO=/builds/worker/fetches/rustc/bin/cargo CARGO_CRATE_NAME=geckoservo CARGO_MANIFEST_DIR=/builds/worker/checkouts/gecko/servo/ports/geckolib CARGO_PKG_AUTHORS='The Servo Project Developers' CARGO_PKG_DESCRIPTION='' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE=MPL-2.0 CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=geckoservo CARGO_PKG_README='' CARGO_PKG_REPOSITORY='' CARGO_PKG_RUST_VERSION='' CARGO_PKG_VERSION=0.0.1 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=0 CARGO_PKG_VERSION_PATCH=1 CARGO_PKG_VERSION_PRE='' LD_LIBRARY_PATH=/builds/worker/workspace/obj-build/release/deps /builds/worker/fetches/sccache/sccache /builds/worker/fetches/rustc/bin/rustc --crate-name geckoservo --edition=2015 servo/ports/geckolib/lib.rs --error-format=json --json=diagnostic-rend[...]
[task 2024-05-30T16:11:45.074Z] 16:11:45    ERROR -  error: structure field `brokenAddBlockers` should have a snake case name
[task 2024-05-30T16:11:45.074Z] 16:11:45     INFO -       --> /builds/worker/workspace/obj-build/toolkit/components/glean/api/src/metrics.rs:45781:15
[task 2024-05-30T16:11:45.075Z] 16:11:45     INFO -        |
[task 2024-05-30T16:11:45.075Z] 16:11:45     INFO -  45781 |           pub brokenAddBlockers: AsyncShutdownTimeoutObjectItemBrokenaddblockers,
[task 2024-05-30T16:11:45.075Z] 16:11:45     INFO -        |               ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `broken_add_blockers`
[task 2024-05-30T16:11:45.076Z] 16:11:45     INFO -        |
[task 2024-05-30T16:11:45.076Z] 16:11:45     INFO -        = note: `-D non-snake-case` implied by `-D warnings`
[task 2024-05-30T16:11:45.076Z] 16:11:45     INFO -        = help: to override `-D warnings` add `#[allow(non_snake_case)]`
[task 2024-05-30T16:11:45.076Z] 16:11:45    ERROR -  error: could not compile `firefox-on-glean` (lib) due to 1 previous error

Comment 6

[Alex Franchuk [:afranchuk]]

:janerik This looks like a Glean codegen issue? Or at the very least, a failure in documentation for the object type (regarding assumptions about property name case)? Also I'm not sure why this built fine for me locally (no warnings at all, just retried)?

Comment 7

[Jan-Erik Rediger [:janerik]]

Hm, yeah, that's the wrong casing indeed. I can look into this next week, until then I leave my ni? in as a reminder.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09c404c81d7f
Implement Telemetry Environment metrics as Glean metrics r=gsvelto

Comment 9

[Norisz Fay [:noriszfay]]

Backed out for causing BR bustages

Backout link

Push with failures

Failure log

Comment 10

[Alex Franchuk [:afranchuk]]

mach try auto failed me. The Version field changing to be included in pings caused a trivial test failure.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6875e1a9dc86
Implement Telemetry Environment metrics as Glean metrics r=gsvelto

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6875e1a9dc86

Comment 13

[Jan-Erik Rediger [:janerik]]

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1900312