1900504 - [rustc-1.80] Perma error[E0282]: type annotations needed for `Box<_>`

Status: RESOLVED FIXED

(Core :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mh [at] glandium.org
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=460933413&repo=toolchains
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/czPuVdNmQY6-koIczKTlbQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2024-06-03T23:15:26.138Z] 23:15:26    ERROR -  error[E0282]: type annotations needed for `Box<_>`
[task 2024-06-03T23:15:26.138Z] 23:15:26     INFO -    --> /opt/worker/tasks/task_171225436694629/checkouts/gecko/third_party/rust/time/src/format_description/parse/mod.rs:83:9
[task 2024-06-03T23:15:26.138Z] 23:15:26     INFO -     |
[task 2024-06-03T23:15:26.138Z] 23:15:26     INFO -  83 |     let items = format_items
[task 2024-06-03T23:15:26.138Z] 23:15:26     INFO -     |         ^^^^^
[task 2024-06-03T23:15:26.138Z] 23:15:26     INFO -  ...
[task 2024-06-03T23:15:26.138Z] 23:15:26     INFO -  86 |     Ok(items.into())
[task 2024-06-03T23:15:26.138Z] 23:15:26     INFO -     |              ---- type must be known at this point
[task 2024-06-03T23:15:26.138Z] 23:15:26     INFO -     |
[task 2024-06-03T23:15:26.138Z] 23:15:26     INFO -  help: consider giving `items` an explicit type, where the placeholders `_` are specified
[task 2024-06-03T23:15:26.139Z] 23:15:26     INFO -     |
[task 2024-06-03T23:15:26.139Z] 23:15:26     INFO -  83 |     let items: Box<_> = format_items
[task 2024-06-03T23:15:26.139Z] 23:15:26     INFO -     |              ++++++++
[task 2024-06-03T23:15:27.161Z] 23:15:27     INFO -  For more information about this error, try `rustc --explain E0282`.
[task 2024-06-03T23:15:27.180Z] 23:15:27     INFO -  warning: `time` (lib) generated 10 warnings
[task 2024-06-03T23:15:27.180Z] 23:15:27    ERROR -  error: could not compile `time` (lib) due to 1 previous error; 10 warnings emitted

Comment 1

[Mike Hommey [:glandium]]

Alex, could you split the time update off bug 1743983 and bump it to 0.3.36? That would fix this issue.

Comment 2

[Alex Franchuk [:afranchuk]]

Working on it now.

Comment 3

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1900504 - Update the time crate to version 0.3.36 r=glandium

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9a0b7c1e8a2
Update the time crate to version 0.3.36 r=glandium,supply-chain-reviewers

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a9a0b7c1e8a2

Comment 6

[Intermittent Failures Robot]

1 failures in 3649 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• toolchains: 1

Platform and build breakdown:

• macosx64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1900504&startday=2024-06-03&endday=2024-06-09&tree=all

Comment 7

[Florin Bilt]

Do you think this patch might cause the following regression?

Perfherder has detected a build_metrics performance change from push cd09151a1c46cba9d56b45684eebc6465a5e869c.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.13%	installer size	osx-aarch64-shippable	aarch64 nightly	92,055,786.08 -> 92,175,068.50

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 632

For more information on performance sheriffing please see our FAQ.

Comment 8

[Alex Franchuk [:afranchuk]]

It's hard to say (it's an update to third-party code after all), but based on the net ~2.5 kLOC change, I think it slightly unlikely (it's unlikely all that code is used by us, so it would be removed). Not that LOC is strictly a determining factor in binary size, but it can provide some guidance. If no other bugs seem a likely cause, then you can attribute that change to this bug (it is certainly a possible cause). However this won't be backed out, so we'd accept it as a necessary regression.