1900576 - Port bug 1881272: update desktop_l10n.py to support l10n target string repo in github

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, enhancement)

Description

[Brendan Abolivier [:babolivier]]

https://phabricator.services.mozilla.com/D211983 removed gecko_locale_revisions, which we access here: https://searchfox.org/comm-central/rev/1eaef9cef90cb31c86ab876f36c75dbbb8f62075/taskcluster/scripts/desktop_comm_l10n.py#217

This is causing failures in the l10n pre-shippable job on comm-central: https://treeherder.mozilla.org/jobs?repo=comm-central&revision=370dfc98b74038961e914ca01257f92ec4b164e9&selectedTaskRun=Fyb3V7EWR4yASXsoEEqPfg.0

[task 2024-06-04T11:27:28.338Z] 11:27:28    FATAL - Uncaught exception: Traceback (most recent call last):
[task 2024-06-04T11:27:28.338Z] 11:27:28    FATAL -   File "/builds/worker/checkouts/gecko/testing/mozharness/mozharness/base/script.py", line 2384, in run
[task 2024-06-04T11:27:28.338Z] 11:27:28    FATAL -     self.run_action(action)
[task 2024-06-04T11:27:28.338Z] 11:27:28    FATAL -   File "/builds/worker/checkouts/gecko/testing/mozharness/mozharness/base/script.py", line 2318, in run_action
[task 2024-06-04T11:27:28.338Z] 11:27:28    FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
[task 2024-06-04T11:27:28.338Z] 11:27:28    FATAL -   File "/builds/worker/checkouts/gecko/testing/mozharness/mozharness/base/script.py", line 2270, in _possibly_run_method
[task 2024-06-04T11:27:28.338Z] 11:27:28    FATAL -     return getattr(self, method_name)()
[task 2024-06-04T11:27:28.338Z] 11:27:28    FATAL -   File "/builds/worker/checkouts/gecko/comm/taskcluster/scripts/desktop_comm_l10n.py", line 217, in gen_changesets
[task 2024-06-04T11:27:28.338Z] 11:27:28    FATAL -     "gecko_strings": self.gecko_locale_revisions,
[task 2024-06-04T11:27:28.338Z] 11:27:28    FATAL - AttributeError: 'CommMultiLocale' object has no attribute 'gecko_locale_revisions'
[task 2024-06-04T11:27:28.338Z] 11:27:28    FATAL - Running post_fatal callback...
[task 2024-06-04T11:27:28.338Z] 11:27:28    FATAL - Exiting -1

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1900576 - Port bug 1881272: Refactor desktop_comm_l10n after upstream changes to support Git. r=#thunderbird-build-system-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7f0876ecb4a8
Port bug 1881272: Refactor desktop_comm_l10n after upstream changes to support Git. r=dandarnell

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9405500 [details]
Bug 1900576 - Port bug 1881272: Refactor desktop_comm_l10n after upstream changes to support Git. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: localization
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky):
Medium risk but required. Patch uplifts cleanly to comm-esr115.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9405500 [details]
Bug 1900576 - Port bug 1881272: Refactor desktop_comm_l10n after upstream changes to support Git. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for esr115

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 115.13.0:
https://hg.mozilla.org/releases/comm-esr115/rev/854bd9947041