1900677 - Add a capability to recycle DataSourceSurface allocated in CanvasTranslator::LookupSourceSurfaceFromSurfaceDescriptor() if possible

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

During working for Bug 1899231, allocating DataSourceSurface in BufferTextureHost::GetAsSurface() is a bottle neck during canvas2dvideo with Firefox Profiler on Linux.

• https://profiler.firefox.com/from-url/https%3A%2F%2Ffirefox-ci-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2Fa8jLSE-DTp-5_Kkldq9nxw%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_webgl.zip/calltree/?v=10
• https://profiler.firefox.com/from-url/https%3A%2F%2Ffirefox-ci-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2Fa8jLSE-DTp-5_Kkldq9nxw%2Fruns%2F0%2Fartifacts%2Fpublic%2Ftest_info%2Fprofile_webgl.zip/calltree/?file=profile_canvas2dvideo%2Fbenchmarks_video_video_upload.html_pagecycle_1%2Fcycle_0.profile&globalTrackOrder=a0w9&hiddenGlobalTracks=1w3&hiddenLocalTracksByPid=3089-01~3253-0~3174-0~3271-0&range=1614m218&thread=3&v=10

Then it seems better to recycle DataSourceSurface.

Comment 1

[Sotaro Ikeda [:sotaro]]

DataSourceSurface allocated in CanvasTranslator::LookupSourceSurfaceFromSurfaceDescriptor() is released soon in RecordedDrawSurfaceDescriptor::PlayEvent().

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1900677 - Add a capability to recycle DataSourceSurface allocated in CanvasTranslator::LookupSourceSurfaceFromSurfaceDescriptor() if possible

Comment 3

[Sotaro Ikeda [:sotaro]]

With default gecko, Firefox profiler with canvas2dvideo.

• canvas2dvideo profile on Linux
  • https://share.firefox.dev/4aUazfj
• canvas2dvideo profile on MacOS
  • https://share.firefox.dev/3x5oBgu

Both on Linux and on MacOS, 100% CPU was used on CanvasRenderer thread.

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=a8jLSE-DTp-5_Kkldq9nxw.0&revision=779c6bdf96bdc20abbeca35c76c9ef6c9b65c8fb

Comment 4

[Sotaro Ikeda [:sotaro]]

deleted

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23623797fb75
Recycle DataSourceSurface allocated in CanvasTranslator::LookupSourceSurfaceFromSurfaceDescriptor() if possible r=gfx-reviewers,lsalzman

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing mediasource related wpt failures

Backout link

Push with failures

Failure log

Comment 7

[Sotaro Ikeda [:sotaro]]

Hmm, timing change seemed to cause the problem.

Comment 8

[Sotaro Ikeda [:sotaro]]

Going to disable the recycling by pref for now.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eee43724710b
Add a capability to recycle DataSourceSurface allocated in CanvasTranslator::LookupSourceSurfaceFromSurfaceDescriptor() if possible r=gfx-reviewers,lsalzman

Comment 10

[Aron Cseh [:acseh]]

https://hg.mozilla.org/mozilla-central/rev/eee43724710b

Comment 11

[Sotaro Ikeda [:sotaro]]

The problem of comment 6 happened because of SharedContextWebgl::DrawRectAccel() implementation.

• https://searchfox.org/mozilla-central/rev/59d854a90e036cfa77f3c5b70c8c6ef1d60ebb98/dom/canvas/DrawTargetWebgl.cpp#2412
• https://searchfox.org/mozilla-central/rev/59d854a90e036cfa77f3c5b70c8c6ef1d60ebb98/dom/canvas/DrawTargetWebgl.cpp#2544

When aForceUpdate is not set, recycled DataSourceSurface data is not uploaded to texture.

And DrawTargetWebgl::DrawSurface(). Does not request force update.