1901192 - Recycled DataSourceSurface is not uploaded by using DrawTargetWebgl::DrawSurface() in RecordedDrawSurfaceDescriptor::PlayEvent()

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Sotaro Ikeda [:sotaro]]

When DataSourceSurface is recycled in CanvasTranslator::LookupSourceSurfaceFromSurfaceDescriptor(), recycled DataSourceSurface is not uploaded by using DrawTargetWebgl::DrawSurface(). See Bug 1900677 comment 11.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1901192 - Force uploading recycled DataSourceSurface by CanvasTranslator

Comment 2

[Sotaro Ikeda [:sotaro]]

With default gecko, Firefox profiler with canvas2dvideo.

• canvas2dvideo profile on Linux
  • https://share.firefox.dev/4aUazfj
• canvas2dvideo profile on MacOS
  • https://share.firefox.dev/3x5oBgu

On Linux in CanvasRenderer thread, 70% CPU was used for allocating and destroying DataSourceSurface. on MacOS in CanvasRenderer thread, 50% CPU was used for allocating and destroying DataSourceSurface. It is not good.

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=a8jLSE-DTp-5_Kkldq9nxw.0&revision=779c6bdf96bdc20abbeca35c76c9ef6c9b65c8fb

Comment 3

[Sotaro Ikeda [:sotaro]]

With D212903 , the cpu task for allocating and destroying DataSourceSurface was removed. The significant amount of CPU tasks were removed.

• canvas2dvideo profile on Linux
  • https://share.firefox.dev/4aVasA8
• canvas2dvideo profile on MacOS
  • https://share.firefox.dev/45kcvgk

https://treeherder.mozilla.org/jobs?repo=try&revision=e045b71f75a9701bec7a03af9e3b9a9be1f66ca3

Comment 4

[Sotaro Ikeda [:sotaro]]

However, talos' canvas2dvideo score regressed significantly: with default gecko, the CanvasRenderer thread was too slow, slowing down the tick() and WebRender transactions. With default gecko, the current canvas2dvideo score is not valid.

https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=135ab309ef8f2d5039c9403d6c8b7b0eb0882d73&newProject=try&newRevision=c963dd349a2e850b2e7696360c1cf596e83f9df8&framework=1&page=1&showOnlyImportant=1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4d3452deb40
Force uploading recycled DataSourceSurface by CanvasTranslator r=gfx-reviewers,lsalzman

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b4d3452deb40